From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11814 invoked by alias); 2 Jul 2013 16:51:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11803 invoked by uid 89); 2 Jul 2013 16:51:32 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 16:51:31 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Uu3nc-0006li-TP from Luis_Gustavo@mentor.com ; Tue, 02 Jul 2013 09:51:28 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 2 Jul 2013 09:51:28 -0700 Received: from [172.30.15.158] ([172.30.15.158]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 2 Jul 2013 09:51:27 -0700 Message-ID: <51D3050C.4070309@codesourcery.com> Date: Tue, 02 Jul 2013 16:51:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Tom Tromey CC: "'gdb-patches@sourceware.org'" Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64. References: <51D1AD43.3060904@codesourcery.com> <8761wsgb8i.fsf@fleche.redhat.com> In-Reply-To: <8761wsgb8i.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00083.txt.bz2 On 07/02/2013 01:47 PM, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > > Luis> Skipping this test for MIPS is not the right thing as some ABI's are > Luis> 32-bit and so should be tested against the usual set of SREC, IHEX and > Luis> TEKHEX formats. > > Luis> The attached patch checks for the N64 ABI and sets the internal flag > Luis> is64bitonly accordingly, skipping the SREC, IHEX and TEKHEX tests. > > Should this be made more generic? > Say, test for "sizeof(&main) != 4"? It could be, if we can guarantee oddball architectures don't use pointers and addresses of strange sizes, say, an arch that declares function pointers of 4 bytes.