From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5673 invoked by alias); 2 Jul 2013 14:45:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5652 invoked by uid 89); 2 Jul 2013 14:45:19 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 14:45:18 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Uu1pV-0001Vr-2Q from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Tue, 02 Jul 2013 07:45:17 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 2 Jul 2013 07:45:16 -0700 Received: from [172.30.15.158] ([172.30.15.158]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 2 Jul 2013 07:45:16 -0700 Message-ID: <51D2E779.4040209@codesourcery.com> Date: Tue, 02 Jul 2013 14:45:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Yao Qi CC: "'gdb-patches@sourceware.org'" Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64. References: <51D1AD43.3060904@codesourcery.com> <51D2E59E.7080300@codesourcery.com> In-Reply-To: <51D2E59E.7080300@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-07/txt/msg00075.txt.bz2 On 07/02/2013 11:37 AM, Yao Qi wrote: > On 07/02/2013 12:24 AM, Luis Machado wrote: >> +# Since SREC, IHEX and TEKHEX cannot handle 64-bit addresses for >> +# MIPS64, stop testing if we have a 64-bit MIPS program. >> +if {[istarget "mips*-*-*"]} then { >> + send_gdb "show mips abi\n" >> + gdb_expect { >> + -re ".*n64.*$gdb_prompt $" { >> + set is64bitonly "yes" >> + } >> + } >> +} >> + > > Luis, > this patch looks reasonable to me. Probably, we should move the code to > the place close to the existing code setting "is64bitonly" too. > For MIPS we need to load the binary first to be able to tell if we really have a N64 ABI or not. That is why this check is a bit later in the code compared to the other checks. Does that make sense? Luis