From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3955 invoked by alias); 2 Jul 2013 14:44:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3946 invoked by uid 89); 2 Jul 2013 14:44:54 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_RG autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 14:44:53 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Uu1p6-0001Sz-2Z from Yao_Qi@mentor.com ; Tue, 02 Jul 2013 07:44:52 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 2 Jul 2013 07:44:51 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Tue, 2 Jul 2013 07:44:49 -0700 Message-ID: <51D2E749.9020604@codesourcery.com> Date: Tue, 02 Jul 2013 14:44:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml Subject: Re: [PATCH] Fix PR 15692 -dprintf-insert does not accept double quotes References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-07/txt/msg00074.txt.bz2 On 07/02/2013 09:30 PM, Hui Zhu wrote: > --- a/gdb/mi/mi-cmd-break.c > +++ b/gdb/mi/mi-cmd-break.c > @@ -128,6 +128,9 @@ mi_argv_to_format (char **argv, int argc > case '\v': > obstack_grow (&obstack, "\\v", 2); > break; > + case '"': > + obstack_grow (&obstack, "\\\"", 2); > + break; > default: > if (isprint (argv[0][i])) > obstack_grow (&obstack, argv[0] + i, 1); IWBN to add a test case to show that GDB handles double quotes correctly after this fix. -- Yao (齐尧)