From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103133-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30187 invoked by alias); 2 Jul 2013 14:37:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30176 invoked by uid 89); 2 Jul 2013 14:37:46 -0000
X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 02 Jul 2013 14:37:45 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1Uu1iB-0000rk-Kb from Yao_Qi@mentor.com 	for gdb-patches@sourceware.org; Tue, 02 Jul 2013 07:37:43 -0700
Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Tue, 2 Jul 2013 07:37:43 -0700
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Tue, 2 Jul 2013 07:37:42 -0700
Message-ID: <51D2E59E.7080300@codesourcery.com>
Date: Tue, 02 Jul 2013 14:37:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: <lgustavo@codesourcery.com>
CC: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, testsuite] Don't run SREC, IHEX and TEKHEX tests for MIPS N64.
References: <51D1AD43.3060904@codesourcery.com>
In-Reply-To: <51D1AD43.3060904@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2013-07/txt/msg00073.txt.bz2

On 07/02/2013 12:24 AM, Luis Machado wrote:
> +# Since SREC, IHEX and TEKHEX cannot handle 64-bit addresses for
> +# MIPS64, stop testing if we have a 64-bit MIPS program.
> +if {[istarget "mips*-*-*"]} then {
> +  send_gdb "show mips abi\n"
> +  gdb_expect {
> +      -re ".*n64.*$gdb_prompt $" {
> +	  set is64bitonly "yes"
> +      }
> +  }
> +}
> +

Luis,
this patch looks reasonable to me.  Probably, we should move the code to 
the place close to the existing code setting "is64bitonly" too.

-- 
Yao (齐尧)