From: Pedro Alves <palves@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] fix PR 15180 "May only run agent-printf on the target"
Date: Mon, 01 Jul 2013 08:10:00 -0000 [thread overview]
Message-ID: <51D13985.9020709@redhat.com> (raw)
In-Reply-To: <CANFwon1j8zhxShFKh0iUOcp-kqdBjm_5bZvAKoFamAxoff-KeA@mail.gmail.com>
On 06/30/2013 04:17 PM, Hui Zhu wrote:
>> > If dprintf style is agent, then the target doesn't report events
>> > for such hits. If we happen to see a trap reported for the
>> > same address as another breakpoint, the trap is surely not explained
>> > by the dprintf. IOW, we shouldn't have a bpstat a dprintf w/ style
>> > agent at all. What is need is to override the breakpoint_hit method
>> > of dprintf_breakpoint_ops to always return false for agent style dprintfs.
>> >
>> > Or maybe I'm missing something. I have a hard time going from
>> > the bug description in the PR to the patch.
> OK. I add dprintf_check_status in the new patch according to your comments.
>
But I suggested the breakpoint_ops->breakpoint_hit not breakpoint_ops->check_status.
An agent-style dprintf is just like a tracepoint. It can't ever explain
a stop. See tracepoint_breakpoint_hit. If it didn't work, please explain why.
--
Pedro Alves
next prev parent reply other threads:[~2013-07-01 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 10:12 Hui Zhu
2013-06-26 18:00 ` Pedro Alves
2013-06-30 17:15 ` Hui Zhu
2013-07-01 8:10 ` Pedro Alves [this message]
2013-07-01 8:51 ` Hui Zhu
2013-07-01 14:29 ` Pedro Alves
2013-07-01 16:08 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D13985.9020709@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox