From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11529 invoked by alias); 28 Jun 2013 17:44:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11520 invoked by uid 89); 28 Jun 2013 17:44:38 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 28 Jun 2013 17:44:37 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5SHiYsx013296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Jun 2013 13:44:34 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5SHiXvD015841; Fri, 28 Jun 2013 13:44:33 -0400 Message-ID: <51CDCB80.1010400@redhat.com> Date: Fri, 28 Jun 2013 17:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/9] Rely on gnulib's unistd.h replacement. References: <20130627185200.6625.10526.stgit@brno.lan> <20130627185229.6625.60141.stgit@brno.lan> <51CD4DEC.6050104@codesourcery.com> In-Reply-To: <51CD4DEC.6050104@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00915.txt.bz2 On 06/28/2013 09:48 AM, Yao Qi wrote: > On 06/28/2013 02:52 AM, Pedro Alves wrote: >> With gnulib's unistd module, we can assume unistd.h is always present, and that >> STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO are always defined. > > So we don't have to check unistd.h by AC_CHECK_HEADERS in > gdb/configure.ac and gdb/gdbserver/configure.ac? > Yeah. I had chickened out on it, thinking it might be still necessary for the following autoconf checks, after seeing that string.h strings.h etc. are still checked too. But if that's the case, then the following the tests that need it should be fixed instead, so I agree if should be removed. Note, however, that autoconf itself through: _AC_INCLUDES_DEFAULT_REQUIREMENTS Always adds the check itself: # On IRIX 5.3, sys/types and inttypes.h are conflicting. AC_CHECK_HEADERS([sys/types.h sys/stat.h stdlib.h string.h memory.h strings.h \ inttypes.h stdint.h unistd.h], [], [], $ac_includes_default) ])# _AC_INCLUDES_DEFAULT_REQUIREMENTS So we'll still end up checking for unistd.h and end up with HAVE_UNISTD_H in config.h/config.h... Found that out after wondering wth I had removed unistd.h, and config.in would still resist changing. :-) -- Pedro Alves