From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10199 invoked by alias); 27 Jun 2013 19:21:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10190 invoked by uid 89); 27 Jun 2013 19:21:03 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 27 Jun 2013 19:21:02 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5RJKw9f025390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Jun 2013 15:20:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5RJKtFs023269; Thu, 27 Jun 2013 15:20:56 -0400 Message-ID: <51CC9097.6000505@redhat.com> Date: Thu, 27 Jun 2013 19:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Mircea Gherzan CC: tromey@redhat.com, jan.kratochvil@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH 7/7] gdbserver: add fallback implementation for memmem References: <1372322622-3216-1-git-send-email-mircea.gherzan@intel.com> <1372322622-3216-8-git-send-email-mircea.gherzan@intel.com> In-Reply-To: <1372322622-3216-8-git-send-email-mircea.gherzan@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00852.txt.bz2 I'll review the rest of the series later, but ... On 06/27/2013 09:43 AM, Mircea Gherzan wrote: > The memmem() function is a GNU extension. > > 2013-06-26 Mircea Gherzan > > gdbserver/ > > * configure.ac (AC_CHECK_FUNCS): Add memmem. > * configure: Rebuild. > * config.in: Rebuild. > * server.c (memmem): New function, included only if it's not > already provided by the system. We already pull in a fallback memmem from gnulib. You need to figure out why that isn't working for you. -- Pedro Alves