Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mircea Gherzan <mircea.gherzan@intel.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, yao@codesourcery.com, tromey@redhat.com
Subject: Re: [PATCH] gdbserver: fix the standalone build
Date: Thu, 27 Jun 2013 18:42:00 -0000	[thread overview]
Message-ID: <51CC7ECE.4030507@intel.com> (raw)
In-Reply-To: <51CC7A4A.2080700@redhat.com>

On 27.06.2013 19:45, Pedro Alves wrote:
> On 06/27/2013 06:42 PM, Pedro Alves wrote:
>> On 06/27/2013 06:38 PM, Pedro Alves wrote:
>>
>>> But instead of that, then, which I'd call a hack, we should
>>> instead do:
>>
>> Or better yet, do as Tom suggests, as I believe we do want
>> to print the non-canonical string here, exactly as --host
>> was specified.
>>
>
> Even better, if $host_alias is empty, we should print $host, IMO:
>
>   $ ./gdbserver --version
>   GNU gdbserver (GDB) 7.6.0.20130529-cvs
>   Copyright (C) 2013 Free Software Foundation, Inc.
>   gdbserver is free software, covered by the GNU General Public License.
>   This gdbserver was configured as ""

So in the end it's a matter of either
1. quoting the parameters when calling create-version.sh and getting an 
empty string at --version, OR
2. using $host when $host_alias is empty

I favour the latter. Tom, what do think?

Thanks,
Mircea

-- 

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


  reply	other threads:[~2013-06-27 18:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-27 14:58 Mircea Gherzan
2013-06-27 15:04 ` Pedro Alves
2013-06-27 16:56   ` Mircea Gherzan
2013-06-27 17:42     ` Pedro Alves
2013-06-27 17:46       ` Pedro Alves
2013-06-27 17:46         ` Pedro Alves
2013-06-27 18:42           ` Mircea Gherzan [this message]
2013-06-27 18:52             ` Tom Tromey
2013-06-27 17:29 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51CC7ECE.4030507@intel.com \
    --to=mircea.gherzan@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox