From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9194 invoked by alias); 26 Jun 2013 17:58:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9178 invoked by uid 89); 26 Jun 2013 17:58:08 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 26 Jun 2013 17:58:06 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5QHw4FM025660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Jun 2013 13:58:04 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5QHw2rZ030535; Wed, 26 Jun 2013 13:58:03 -0400 Message-ID: <51CB2BAA.1070507@redhat.com> Date: Wed, 26 Jun 2013 18:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml Subject: Re: [PATCH] fix PR 15180 "May only run agent-printf on the target" References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00787.txt.bz2 On 06/17/2013 08:47 AM, Hui Zhu wrote: > Hi, > > This patch is for PR 15180 too. Because it depends on patch in > http://sourceware.org/ml/gdb-patches/2013-06/msg00139.html > So I post it in another thread. > > It make dprintf_after_condition_true doesn't do actions if dprintf > style is agent. Because the actions is already did in agent. If dprintf style is agent, then the target doesn't report events for such hits. If we happen to see a trap reported for the same address as another breakpoint, the trap is surely not explained by the dprintf. IOW, we shouldn't have a bpstat a dprintf w/ style agent at all. What is need is to override the breakpoint_hit method of dprintf_breakpoint_ops to always return false for agent style dprintfs. Or maybe I'm missing something. I have a hard time going from the bug description in the PR to the patch. > > The test patch test the issue about 15180. Hmm, I get: Running target native-gdbserver Using ../../../src/gdb/testsuite/boards/../boards/native-gdbserver.exp as board description file for target. Using ../../../src/gdb/testsuite/config/gdbserver.exp as tool-and-target-specific interface file. Running ../../../src/gdb/testsuite/gdb.base/dprintf-same-addr.exp ... FAIL: gdb.base/dprintf-same-addr.exp: agent: First continue (the program exited) FAIL: gdb.base/dprintf-same-addr.exp: agent: Second continue (the program is no longer running) FAIL: gdb.base/dprintf-same-addr.exp: agent: check i === gdb Summary === # of expected passes 16 # of unexpected failures 3 # of unsupported tests 1 > > Thanks, > Hui > > 2013-06-17 Hui Zhu > > PR gdb/15180 > * breakpoint.c (dprintf_after_condition_true): Check dprintf style > before do actions. > > 2013-06-17 Hui Zhu > > PR gdb/15180 > * gdb.base/dprintf-same-addr.c: New file. > * gdb.base/dprintf-same-addr.exp: New file. > -- Pedro Alves