From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24639 invoked by alias); 25 Jun 2013 18:42:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24630 invoked by uid 89); 25 Jun 2013 18:42:24 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_EG autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 25 Jun 2013 18:42:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PIgLA3005303 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 14:42:21 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5PIgKK5027990; Tue, 25 Jun 2013 14:42:20 -0400 Message-ID: <51C9E48B.7050605@redhat.com> Date: Tue, 25 Jun 2013 19:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Kaushik Phatak CC: "gdb-patches@sourceware.org" Subject: Re: [RFA 4/5] New port: CR16: gdbserver References: <50CB742E.9090506@redhat.com> <50F97ABF.4060203@redhat.com> <50FFE596.20303@redhat.com> <50FFF730.9050108@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00736.txt.bz2 On 06/19/2013 02:28 PM, Kaushik Phatak wrote: > The below gdbserver port has following changes, > 1. Remove register pair access over remote protocol in the .dat file. > This allows for matching of the register numbers in the gdbserver with those > in linux-tdep.c. This was done by simplifying the PTRACE_GETREGS inside kernel > to read single registers. > 2. Remove support for "r0r1_orig" register. This is a kernel internal register > and need not be user visible. > 3. Set cr16_num_regs to 20 and PC_REGNUM to 16. This will now match the gdb port. > 4. Add registers pc,usp,ra to the "expedite" set. > 5. Move the ptrace macro defines like PT_TEXT_ADDR from linux-low.c to the kernel's > ptrace.h I'm not clear on point #2, but the rest sounds excellent. Thanks! > + > +/* We only place breakpoints in empty marker functions, and thread locking > + is outside of the function. So rather than importing software single-step, > + we can just run until exit. */ > +static CORE_ADDR Add empty line between describing comment and function definition. > +cr16_reinsert_addr (void) > +{ > + struct regcache *regcache = get_thread_regcache (current_inferior, 1); > + unsigned long pc; > + > + /* R14/Ra is return address register */ "... is the return ..." Other than that, this looks good. -- Pedro Alves