From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11603 invoked by alias); 25 Jun 2013 17:31:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11574 invoked by uid 89); 25 Jun 2013 17:31:51 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 25 Jun 2013 17:31:50 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PHVbTn022799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 13:31:37 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5PHVZdR019240; Tue, 25 Jun 2013 13:31:37 -0400 Message-ID: <51C9D3F6.8090202@redhat.com> Date: Tue, 25 Jun 2013 18:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 6/6] New test: gdb.trace/mi-trace-frame-collected.exp References: <1370610493-26468-1-git-send-email-yao@codesourcery.com> <1371086914-8398-1-git-send-email-yao@codesourcery.com> <1371086914-8398-7-git-send-email-yao@codesourcery.com> In-Reply-To: <1371086914-8398-7-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00734.txt.bz2 On 06/13/2013 02:28 AM, Yao Qi wrote: > +# Define an action. > +set pcreg "" Suggest giving it an empty line after the comment, as the set is not yet defining the action. > +if [is_amd64_regs_target] { > + set pcreg "rip" > +} elseif [is_x86_like_target] { > + set pcreg "eip" > +} else { > + # Other ports support tracepoing should set the name of pc > + # register. # Other ports that support tracepoints should set the name # of the pc register here. > + fail "set the number and the name of pc register" > + return -1 > +} > + > +mi_gdb_test "-break-commands 3 \"collect gdb_char_test\" \"collect gdb_union1_test\" \"collect gdb_struct1_test.l\" \"collect gdb_arr_test\[0\]\" \"collect $${pcreg}\" \"teval \$tsv += 1\" \"collect \$tsv\" \"end\" " \ > + {\^done} "set action" > + > +mi_gdb_test "-break-insert -a gdb_c_test" \ > + "\\^done,bkpt=\{number=\"${decimal}\",type=\"tracepoint\".*\"\}" \ > + "insert tracepoint on gdb_c_test" > +# Collect a global variable to make sure no registers are collected > +# expect PC. Typo: except. I do that one often too. :-) Suggest s/make sure/be sure/. > +# Test MI command '-trace-frame-collected' from different data source. "from different" threw me off a second (different compared to what?). Suggest: # Test the MI command '-trace-frame-collected' with DATA_SOURCE as # trace data source. > + > +proc test_trace_frame_collected { data_source } { > + global decimal hex > + global mi_gdb_prompt > + This looks OK to me with those changes. Thanks! -- Pedro Alves