From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27666 invoked by alias); 25 Jun 2013 15:32:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27654 invoked by uid 89); 25 Jun 2013 15:32:36 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 25 Jun 2013 15:32:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PFWWk3025343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 11:32:33 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5PFWVOm001023; Tue, 25 Jun 2013 11:32:32 -0400 Message-ID: <51C9B80F.5060507@redhat.com> Date: Tue, 25 Jun 2013 15:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/6] Move code to get_traceframe_location. References: <1370610493-26468-1-git-send-email-yao@codesourcery.com> <1371086914-8398-1-git-send-email-yao@codesourcery.com> <1371086914-8398-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1371086914-8398-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00714.txt.bz2 On 06/13/2013 02:28 AM, Yao Qi wrote: > This patch is a refactor patch. It moves some code into a new > function get_traceframe_location, which will be shared in the next > patch in this series. > +/* Return bp_location of the tracepoint associated with the current > + traceframe. Set *STEPPING_FRAME_P to 1 if the current traceframe > + is the stepping traceframe. */ s/is the/is a/ > 2013-06-13 Pedro Alves > Yao Qi > > * tracepoint.c (trace_dump_command): Move code to ... > (get_traceframe_location): ... here. New. OK. Thanks, -- Pedro Alves