From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22801 invoked by alias); 25 Jun 2013 15:28:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22792 invoked by uid 89); 25 Jun 2013 15:28:03 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 25 Jun 2013 15:28:02 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5PFS0OG009838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 25 Jun 2013 11:28:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5PFRwxR030029; Tue, 25 Jun 2013 11:27:59 -0400 Message-ID: <51C9B6FE.1070208@redhat.com> Date: Tue, 25 Jun 2013 15:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/6] Remove global variable tracepoint_list and stepping_list. References: <1370610493-26468-1-git-send-email-yao@codesourcery.com> <1371086914-8398-1-git-send-email-yao@codesourcery.com> <1371086914-8398-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1371086914-8398-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00712.txt.bz2 On 06/13/2013 02:28 AM, Yao Qi wrote: > This patch is a refactor patch. Simply, it removes two global > variables tracepoint_list and stepping_list. > > gdb: > > 2013-06-13 Pedro Alves > Yao Qi > > * tracepoint.c (tracepoint_list, stepping_list): Remove. > (clear_collection_list): Free fields 'aexpre_list' and 'list' in > collection_list. > (do_clear_collection_list, init_collection_list): New. > (encode_actions): Add local variables 'tracepoint_list' and > 'stepping_list'. Call init_collection_list and make cleanup which > calls do_clear_collection_list. Don't call clear_collection_list. > (_initialize_tracepoint): Delete references to 'tracepoint_list' > and 'stepping_list'. OK, thanks. -- Pedro Alves