From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15181 invoked by alias); 24 Jun 2013 17:33:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15171 invoked by uid 89); 24 Jun 2013 17:33:58 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 24 Jun 2013 17:33:58 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5OHXvY5014119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Jun 2013 13:33:57 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5OHXtDT025599; Mon, 24 Jun 2013 13:33:56 -0400 Message-ID: <51C88303.10006@redhat.com> Date: Mon, 24 Jun 2013 17:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 08/16] push last_program_signals_packet into struct remote_state References: <1371835506-15691-1-git-send-email-tromey@redhat.com> <1371835506-15691-9-git-send-email-tromey@redhat.com> In-Reply-To: <1371835506-15691-9-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00664.txt.bz2 On 06/21/2013 06:24 PM, Tom Tromey wrote: > + /* The last QProgramSignals packet sent to the target. We bypass > + sending a new program signals list down to the target if the new > + packet is exactly the same as the last we sent. IOW, we only let > + the target know about program signals list changes. */ > + > + char *last_program_signals_packet; I noticed a couple of the patches add an empty line between comment and variable, while the rest of the structure doesn't do that. -- Pedro Alves