From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13924 invoked by alias); 24 Jun 2013 17:32:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13915 invoked by uid 89); 24 Jun 2013 17:32:20 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 24 Jun 2013 17:32:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5OHWIx0023737 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 Jun 2013 13:32:18 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5OHWHce021596; Mon, 24 Jun 2013 13:32:18 -0400 Message-ID: <51C882A1.4030604@redhat.com> Date: Mon, 24 Jun 2013 17:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 16/16] move some static thread state into remote_state References: <1371835506-15691-1-git-send-email-tromey@redhat.com> <1371835506-15691-17-git-send-email-tromey@redhat.com> In-Reply-To: <1371835506-15691-17-git-send-email-tromey@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00663.txt.bz2 On 06/21/2013 06:25 PM, Tom Tromey wrote: > This moves a few static variables from thread-info functions into > remote_state. Pedro said on irc that these functions implement the > ancient thread-discovery method and that he wouldn't be surprised if > they had rotted; nevertheless it seems safer to me to make them > explicitly per-remote. Yeah. > static int use_range_stepping = 1; > > +#define OPAQUETHREADBYTES 8 > + > +/* a 64 bit opaque identifier */ > +typedef unsigned char threadref[OPAQUETHREADBYTES]; > + > +#define MAXTHREADLISTRESULTS 32 > + ... > { > /* FIXME: This is a good reason to drop the packet. */ > /* Possably, there is a duplicate response. */ > @@ -2561,18 +2566,15 @@ remote_get_threadlist (int startflag, threadref *nextthread, int result_limit, > > /* About this many threadisds fit in a packet. */ This comment should be moved as well along with the macro. > > -#define MAXTHREADLISTRESULTS 32 > - -- Pedro Alves