Re: [PATCH 00/16] clean up remote.c state

Yao Qi
2013-07-05T03:07:23Z

On 06/22/2013 01:24 AM, Tom Tromey wrote:
> * I think the client-stop notification code needs some update

Yes, the global 'notif_queue' should be moved for each remote state.

My pending patches on supported notifications and annexes probably
should be updated for per remote target as well, because different
remote targets may have different supported notifications and annexes.

[PATCH v4 0/5] MI notification on trace started/stopped
http://sourceware.org/ml/gdb-patches/2013-04/msg00019.html

I am not sure we are still interested in this patch series, as I get no
response after a recent ping to Pedro on June.

> After this series goes in, I propose that all future remote.c changes
> be reviewed to ensure that remote state is in remote_state and not a
> new global variable.
>

I agree. The 'trace started/stopped' patch series were submitted some
months ago, IWBN to review them now, and then I'd like to convert the
whole async remote notification to a per remote target manner in the
next step. It will save a lot of efforts on rewriting patches,
re-splitting and rebasing. WDYT?

--
Yao (é½å°§)