From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30654 invoked by alias); 20 Jun 2013 13:39:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30586 invoked by uid 89); 20 Jun 2013 13:39:16 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 20 Jun 2013 13:39:13 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Upf4x-0003mC-5c from Yao_Qi@mentor.com for gdb-patches@sourceware.org; Thu, 20 Jun 2013 06:39:11 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 20 Jun 2013 06:39:10 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Thu, 20 Jun 2013 06:39:09 -0700 Message-ID: <51C305F0.90008@codesourcery.com> Date: Thu, 20 Jun 2013 14:21:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: Subject: Re: [PATCH 2/3] Move mips hardware watchpoint stuff to common/ References: <1369881867-11372-1-git-send-email-yao@codesourcery.com> <1369881867-11372-3-git-send-email-yao@codesourcery.com> <51B93F00.5090002@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-06/txt/msg00535.txt.bz2 Maciej, Thanks for the review. I'll split this patch. A question to the comment below, On 06/20/2013 06:03 AM, Maciej W. Rozycki wrote: >> +uint32_t mips_linux_watch_get_num_valid (struct pt_watch_regs *regs); >> >+uint32_t mips_linux_watch_get_irw_mask (struct pt_watch_regs *regs, >> >+ int set); >> >+CORE_ADDR mips_linux_watch_get_watchlo (struct pt_watch_regs *regs, >> >+ int set); > The two prototypes above will fit in a single line each. > If we put the prototypes into a single line, the length exceeds the 74-character limit. This is the reason I moved parameter "set" to a new line. Shall we keep them as what they are now? > >> >+int mips_linux_watch_try_one_watch (struct pt_watch_regs *regs, >> >+ CORE_ADDR addr, int len, >> >+ unsigned irw); > The three last arguments above will fit in a single line. Likewise. -- Yao (齐尧)