From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2147 invoked by alias); 19 Jun 2013 20:14:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2019 invoked by uid 89); 19 Jun 2013 20:13:58 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 20:13:57 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5JKDsvx010214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Jun 2013 16:13:55 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r5JKDroQ021481; Wed, 19 Jun 2013 16:13:54 -0400 Message-ID: <51C21101.1090904@redhat.com> Date: Wed, 19 Jun 2013 20:37:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: lgustavo@codesourcery.com CC: "'gdb-patches@sourceware.org'" Subject: Re: [PATCH, testsuite] Fix subst.exp failure when GDB is configured with --with-relocated-sources References: <51C209FC.3040206@codesourcery.com> In-Reply-To: <51C209FC.3040206@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00512.txt.bz2 On 06/19/2013 08:43 PM, Luis Machado wrote: > Hi, > > The gdb.base/subst.exp test assumes GDB starts with no default > substitution rules, which is not true if GDB has been configured with > --with-relocated-sources. In that case we start with a default rule, > causing the first test (checking that there are no rules) to fail. > > This patch clears any default substitution rules that may exist prior to > doing all the other tests. > > OK? > Looks obviously correct to me. -- Pedro Alves