From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31446 invoked by alias); 19 Jun 2013 17:37:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31337 invoked by uid 89); 19 Jun 2013 17:37:55 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 17:37:54 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5JHbqMT025490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Jun 2013 13:37:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5JHbpPJ031400; Wed, 19 Jun 2013 13:37:51 -0400 Message-ID: <51C1EC6E.4090402@redhat.com> Date: Wed, 19 Jun 2013 17:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Mike Frysinger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v4] gdb: clean up x86 cpuid implementations References: <201305061451.24861.vapier@gentoo.org> <1371662677-16527-1-git-send-email-vapier@gentoo.org> In-Reply-To: <1371662677-16527-1-git-send-email-vapier@gentoo.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00503.txt.bz2 On 06/19/2013 06:24 PM, Mike Frysinger wrote: > gdb/: > 2013-06-18 Mike Frysinger > > * Makefile.in (HFILES_NO_SRCDIR): Add common/i386-cpuid.h and > common/i386-gcc-cpuid.h. > * common/i386-cpuid.h: New wrapper header around i386-gcc-cpuid.h. > * common/i386-gcc-cpuid.h: Rename from testsuite/gdb.arch/i386-cpuid.h. > Copy the latest version from upstream gcc. > * common/linux-btrace.c: Include i386-cpuid.h. > (intel_supports_btrace): Delete x86 ifdefs and replace inline asm with > call to i386_cpuid. > (cpu_supports_btrace): Likewise. > * go32-nat.c: Include i386-cpuid.h. > (go32_sysinfo): Add (disabled) calls to i386_cpuid with comments. > > gdb/testsuite/: > 2013-06-18 Mike Frysinger > > * gdb.arch/i386-avx.c (have_avx): Change __get_cpuid call to i386_cpuid. > * gdb.arch/i386-avx.exp (additional_flags): Add -I${srcdir}/../common. > * gdb.arch/i386-cpuid.h: Moved to ../common/i386-gcc-cpuid.h. > * gdb.arch/i386-sse.c: Call new i386_cpuid function. > * gdb.arch/i386-see.exp (additional_flags): Add -I${srcdir}/../common. OK. Thanks! -- Pedro Alves