From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10283 invoked by alias); 19 Jun 2013 15:06:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10270 invoked by uid 89); 19 Jun 2013 15:06:03 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 15:06:02 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5JF5wXP022546 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Jun 2013 11:05:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5JF5v80012991; Wed, 19 Jun 2013 11:05:58 -0400 Message-ID: <51C1C8D5.5080809@redhat.com> Date: Wed, 19 Jun 2013 15:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Mike Frysinger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v3] gdb: clean up x86 cpuid implementations References: <201305061451.24861.vapier@gentoo.org> <201306182246.54166.vapier@gentoo.org> <51C1996E.1010001@redhat.com> <201306191053.51709.vapier@gentoo.org> In-Reply-To: <201306191053.51709.vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00494.txt.bz2 On 06/19/2013 03:53 PM, Mike Frysinger wrote: > On Wednesday 19 June 2013 07:43:42 Pedro Alves wrote: >> On 06/19/2013 03:46 AM, Mike Frysinger wrote: >> However, BTW, I failed to notice this before, but: >>> +++ b/gdb/common/i386-cpuid.h >>> @@ -0,0 +1,68 @@ >>> +/* >>> + * Copyright (C) 2007-2013 Free Software Foundation, Inc. >>> + * >>> + * This file is free software; you can redistribute it and/or modify it >>> + * under the terms of the GNU General Public License as published by the >>> + * Free Software Foundation; either version 3, or (at your option) any >>> + * later version. >>> + * >>> + * This file is distributed in the hope that it will be useful, but >>> + * WITHOUT ANY WARRANTY; without even the implied warranty of >>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >>> + * General Public License for more details. >>> + * >>> + * Under Section 7 of GPL version 3, you are granted additional >>> + * permissions described in the GCC Runtime Library Exception, version >>> + * 3.1, as published by the Free Software Foundation. >>> + * >>> + * You should have received a copy of the GNU General Public License and >>> + * a copy of the GCC Runtime Library Exception along with this program; >>> + * see the files COPYING3 and COPYING.RUNTIME respectively. If not, see >>> + * . >>> + */ >> >> This header only contains gdb bits. I don't see a reason for making >> it GPL w/ runtime exception, rather than regular GPLv3+. >> Was it just a copy/paste? > > from the top of the file: > /* > * Helper cpuid.h file copied from gcc-4.8.0. Code in gdb should not > * include this directly, but pull in i386-cpuid.h and use that func. > */ That's the header of i386-gcc-cpuid.h. But I'm talking about (and have quoted) i386-cpuid.h, the wrapper. -- Pedro Alves