From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23253 invoked by alias); 19 Jun 2013 11:43:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23197 invoked by uid 89); 19 Jun 2013 11:43:47 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 11:43:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5JBhiff028390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 19 Jun 2013 07:43:44 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5JBhhjp006412; Wed, 19 Jun 2013 07:43:43 -0400 Message-ID: <51C1996E.1010001@redhat.com> Date: Wed, 19 Jun 2013 12:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Mike Frysinger CC: gdb-patches@sourceware.org Subject: Re: [PATCH v3] gdb: clean up x86 cpuid implementations References: <201305061451.24861.vapier@gentoo.org> <201306181352.59833.vapier@gentoo.org> <51C0A4A3.1000701@redhat.com> <201306182246.54166.vapier@gentoo.org> In-Reply-To: <201306182246.54166.vapier@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00484.txt.bz2 On 06/19/2013 03:46 AM, Mike Frysinger wrote: > i'm not trying to argue against ChangeLogs (i know it's a lost cause w/gdb). > just pointing out that i prefer to wait to the last minute to write it since > it has no real bearing on the actual code review. It does have real bearing on the code review. > here's the ChangeLog entries for this patch. > gdb/: > 2013-06-18 Mike Frysinger > > * Makefile.in (HFILES_NO_SRCDIR): Add common/i386-cpuid.h and > common/i386-gcc-cpuid.h. For example, from the diff alone, one can't tell where these were being added. > * common/i386-cpuid.h: New wrapper header around i386-gcc-cpuid.h. > * common/i386-gcc-cpuid.h: Rename from testsuite/gdb.arch/i386-cpuid.h. > Copy the latest version from upstream gcc. And this is the only mention in the whole patch+intro of the importing from the latest version from upstream gcc. ;-) > * common/linux-btrace.c: Include i386-cpuid.h. > (intel_supports_btrace): Delete x86 ifdefs and replace inline asm with > call to i386_cpuid. > (cpu_supports_btrace): Likewise. > * go32-nat.c: Include i386-cpuid.h. > (go32_sysinfo): Add (disabled) calls to i386_cpuid with comments. > > gdb/testsuite/: > 2013-06-18 Mike Frysinger > > * gdb.arch/i386-avx.c (have_avx): Change __get_cpuid call to i386_cpuid. > * gdb.arch/i386-avx.exp (additional_flags): Add -I${srcdir}/../common. > * gdb.arch/i386-cpuid.h: Moved to ../common/i386-gcc-cpuid.h. > * gdb.arch/i386-sse.c: Call new i386_cpuid function. > * gdb.arch/i386-see.exp (additional_flags): Add -I${srcdir}/../common. FAOD, this is OK. However, BTW, I failed to notice this before, but: > +++ b/gdb/common/i386-cpuid.h > @@ -0,0 +1,68 @@ > +/* > + * Copyright (C) 2007-2013 Free Software Foundation, Inc. > + * > + * This file is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation; either version 3, or (at your option) any > + * later version. > + * > + * This file is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * Under Section 7 of GPL version 3, you are granted additional > + * permissions described in the GCC Runtime Library Exception, version > + * 3.1, as published by the Free Software Foundation. > + * > + * You should have received a copy of the GNU General Public License and > + * a copy of the GCC Runtime Library Exception along with this program; > + * see the files COPYING3 and COPYING.RUNTIME respectively. If not, see > + * . > + */ This header only contains gdb bits. I don't see a reason for making it GPL w/ runtime exception, rather than regular GPLv3+. Was it just a copy/paste? Thanks, -- Pedro Alves