From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26671 invoked by alias); 18 Jun 2013 16:09:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26630 invoked by uid 89); 18 Jun 2013 16:09:32 -0000 X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MISSING_HEADERS,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 18 Jun 2013 16:09:32 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r5IG9Uaw023997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Jun 2013 12:09:31 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r5IG9TWR013719; Tue, 18 Jun 2013 12:09:30 -0400 Message-ID: <51C08639.4080506@redhat.com> Date: Tue, 18 Jun 2013 16:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] ChangeLog width 74 -> 80 References: <20130618150401.GA24795@host2.jankratochvil.net> <51C07B94.3080606@redhat.com> <20130618153005.GA26742@host2.jankratochvil.net> <51C07FCC.6090706@redhat.com> <20130618154752.GA27499@host2.jankratochvil.net> In-Reply-To: <20130618154752.GA27499@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00432.txt.bz2 On 06/18/2013 04:47 PM, Jan Kratochvil wrote: > On Tue, 18 Jun 2013 17:42:04 +0200, Pedro Alves wrote: >> Nobody said anything about bugs. Nor is emacs a non-modern editor. > > I do not understand why you have mentioned Emacs in the first place, it seems > irrelevant for GDB development. Aw, come on, you serious? The patch does: --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -7060,7 +7060,7 @@ For older changes see ChangeLog-2012. Local Variables: mode: change-log left-margin: 8 -fill-column: 74 +fill-column: 80 You surely know that's an emacs setting. And I said: "74 is the default column width in emacs' changelog mode, so it seems the explicit setting is just trying to making sure everyone (that uses emacs) is using the default width, even if one has it overridden in their .emacs file." There's your connection. And we were chatting on irc about where does the 74 come from too... > I find correct to update existing Emacs rules to comply with the specification > but I do not think it matters to mention Emacs when deciding what should be > the GDB standard. Sigh. Straw man. Whatever we end up with, emacs will do the right thing, given "fill-column: XX" in the file, so again, I really don't personally care what the width is. Yes, I agree that requiring different widths for different things is silly. >> As I said, I really don't care that much about the precise width. >> It'd be nice to have it changed consistently across the tree >> though. > > One should define first what is "the tree", currently it contains many > directions which seems irrelevant for GDB decisions to me (tcl, texinfo, > newlib, rda, ...). Sure, the things outside src/gdb/ that are part of gdb as well: src/, src/bfd/, src/include/, src/include/gdb/, etc. > And even in that case GDB already contains Coding Style in gdbint.texinfo > specific only to gdb/ so unifying the ChangeLog standard across the tree > (whatever that means) is only that "nice to have", not a requirement. Sure. I did say "it'd be nice", didn't I? I'm all for consistency, so on my part, if this results in better consistency, go for it. Please update gdb/testsuite/ChangeLog gdb/doc/ChangeLog too though. -- Pedro Alves