From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3930 invoked by alias); 7 Jun 2013 20:50:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3918 invoked by uid 89); 7 Jun 2013 20:50:46 -0000 X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 07 Jun 2013 20:50:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r57KohtG012531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Jun 2013 16:50:43 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r57Kog8C027822; Fri, 7 Jun 2013 16:50:43 -0400 Message-ID: <51B247A1.7010709@redhat.com> Date: Fri, 07 Jun 2013 21:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] Move code to get_traceframe_location. References: <1370610493-26468-1-git-send-email-yao@codesourcery.com> <1370610493-26468-3-git-send-email-yao@codesourcery.com> In-Reply-To: <1370610493-26468-3-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00183.txt.bz2 On 06/07/2013 02:08 PM, Yao Qi wrote: > This patch is a refactor patch. Mainly, but not only. > +static struct bp_location * > +get_traceframe_location (int *stepping_frame_p) > +{ > + if (tracepoint_number == -1) > + error (_("No current trace frame.")); > +} > + > @@ -2982,46 +3024,19 @@ all_tracepoint_actions_and_cleanup (struct breakpoint *t) > static void > trace_dump_command (char *args, int from_tty) > { > - if (tracepoint_number == -1) > - { > - warning (_("No current trace frame.")); > - return; > - } There's a behavior change here. Can you split that out to a separate, preparatory patch, please? -- Pedro Alves