From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1151 invoked by alias); 7 Jun 2013 19:58:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1141 invoked by uid 89); 7 Jun 2013 19:58:37 -0000 X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 07 Jun 2013 19:58:34 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r57JwVDT025169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Jun 2013 15:58:31 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r57JwTRv017055; Fri, 7 Jun 2013 15:58:30 -0400 Message-ID: <51B23B65.8060309@redhat.com> Date: Fri, 07 Jun 2013 20:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Eli Zaretskii CC: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Teach -data-list-register-values to not include unavailable registers References: <1370609650-23595-1-git-send-email-yao@codesourcery.com> <83sj0ut2ob.fsf@gnu.org> In-Reply-To: <83sj0ut2ob.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00179.txt.bz2 Replying for Yao as I wrote this. On 06/07/2013 03:29 PM, Eli Zaretskii wrote: >> From: Yao Qi >> Date: Fri, 7 Jun 2013 20:54:10 +0800 >> >> This patch adds an option --skip-unavailable to MI command >> -data-list-register-values, so that unavailable registers are not >> displayed (on the context of traceframes). > > "Skip unavailable" is double negation. How about -show-available > instead? I think I picked that because "unavailable" terminology is that is what we've been using throughout GDB's output for such values. We display then as literal "" (though also "value not available"). For -show-available, it's not as clear to me that "available" isn't just the generic english word -- I'd have to ponder, 'does this include , '' values, etc. (the answer is yes, it does)? (*) I'm obsessed about it, and this is machine interface anyhow, so no user sees it. (*) we seem to be lacking documentation of what all these "", "" etc., values are. >> Display the registers' contents. @var{fmt} is the format according to >> which the registers' contents are to be returned, followed by an optional >> list of numbers specifying the registers to display. A missing list of >> -numbers indicates that the contents of all the registers must be returned. >> +numbers indicates that the contents of all the registers must be >> +returned. In the context of trace frames, the >> +@code{--skip-unavailable} option indicates that only available >> +(collected) registers are returned. > ^^^^^^^^^^^^ > "are to be returned". And why do you need the first part of that > sentence, about the "context of trace frames"? Does it add anything > to the description? Not really. Meanwhile, we've added uses of outside trace frames, so this it's really better to remove mention of trace frames. -- Pedro Alves