From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18875 invoked by alias); 7 Jun 2013 19:37:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18802 invoked by uid 89); 7 Jun 2013 19:37:38 -0000 X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 07 Jun 2013 19:37:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r57JbZEu027699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Jun 2013 15:37:35 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r57JbXC5025654; Fri, 7 Jun 2013 15:37:34 -0400 Message-ID: <51B2367C.4090104@redhat.com> Date: Fri, 07 Jun 2013 19:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Move some code into get_register. References: <1370608997-20957-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1370608997-20957-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00178.txt.bz2 On 06/07/2013 01:43 PM, Yao Qi wrote: > Hi, > This is a refactor patch. This patch moves some common code in > caller of get_register into get_register, and rename it to > output_register. With this patch, the caller of output_register can > be simplified to some extent. Thanks. > gdb: > > 2013-06-07 Pedro Alves > Yao Qi > > * mi/mi-main.c (get_register): Remove declaration. > (output_register): Declare. > (mi_cmd_data_list_register_values): Remove local variable > 'tuple_cleanup'. Move some code into output_register. > (get_register): Renamed to ... > (output_register): ... it. s/it/this/. Add something like: (output_register): ... This. Output the register's "number" ui_out tuple here. > -/* Output one register's contents in the desired format. */ > +/* Output one register REGNUM's contents in the desired FORMAT. */ You're naming the register now, so, s/one//. Okay with those fixes. Thanks! -- Pedro Alves