From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23046 invoked by alias); 7 Jun 2013 18:41:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23037 invoked by uid 89); 7 Jun 2013 18:41:26 -0000 X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE autolearn=ham version=3.3.1 Received: from mail-wi0-f179.google.com (HELO mail-wi0-f179.google.com) (209.85.212.179) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 07 Jun 2013 18:41:25 +0000 Received: by mail-wi0-f179.google.com with SMTP id hm9so1612062wib.6 for ; Fri, 07 Jun 2013 11:41:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding:x-gm-message-state; bh=yPpltrIxUHqmZ9d/V/HCMeZyv7UDiSxvhxeAwq5UBlI=; b=FttJVmCGiFK60ADdLmg9ZN/LpKaCOxzMyKqYc6RKVo/yRnTQmB0djCHLeRke9cslHq 4rnHsZq10ZrviF9cQAsDqw7RwdRmaYt8Rmwn08XmG/9pujzuN8ctEdP3v3b5K6Hvkzmf CF2+MfBDz4oGztDGfQWtNqjeylpawQWjm2aFzVKR26+yktBhk0NCPsUMeE5tifBcMaG6 5Fvrhp90dlezXZ+V7jH8vD7dF8VuTdNwE2c+Bo7hqWO3X0XOK3g+ah0sZ07rsHF+uIT5 qsggezQySCn8Fix+4jAp4emup++NApGx6MItExeuPt/ErRr//qe/WfQ/30kLfJfBSg4j aFIw== X-Received: by 10.194.123.69 with SMTP id ly5mr3529wjb.29.1370630483730; Fri, 07 Jun 2013 11:41:23 -0700 (PDT) Received: from localhost.localdomain (cpc11-seac20-2-0-cust84.7-2.cable.virginmedia.com. [81.108.156.85]) by mx.google.com with ESMTPSA id f8sm1862174wiv.0.2013.06.07.11.41.22 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 07 Jun 2013 11:41:22 -0700 (PDT) Message-ID: <51B22951.1000601@linaro.org> Date: Fri, 07 Jun 2013 18:58:00 -0000 From: Will Newton User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: gdb-patches@sourceware.org CC: patches@linaro.org Subject: [PATCH] testsuite/gdb.base: Make skip test not rely on undefined behaviour. Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQmf7JVD3aWot9ffAjBpJIkySV0MqHWqkyIsj4K4tyKGrKxBkTjqhTYGLZ9XSEFD0t22KZUa X-SW-Source: 2013-06/txt/msg00174.txt.bz2 The skip test currently relies on the order of evaluation of arguments which is not defined. Use an arithmetic expression where order is defined instead. gdb/testsuite/ChangeLog: 2013-06-07 Will Newton * gdb.base/skip.c: Add results of foo() and bar() before passing to baz(). * gdb.base/skip.c: baz() now takes one argument instead of two. --- gdb/testsuite/gdb.base/skip.c | 4 ++-- gdb/testsuite/gdb.base/skip1.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gdb/testsuite/gdb.base/skip.c b/gdb/testsuite/gdb.base/skip.c index 565ba93..1281d17 100644 --- a/gdb/testsuite/gdb.base/skip.c +++ b/gdb/testsuite/gdb.base/skip.c @@ -1,10 +1,10 @@ int foo(); int bar(); -int baz(int, int); +int baz(int); int main() { - return baz(foo(), bar()); + return baz(bar() + foo()); } int foo() diff --git a/gdb/testsuite/gdb.base/skip1.c b/gdb/testsuite/gdb.base/skip1.c index 2dab5c3..fe63cd6 100644 --- a/gdb/testsuite/gdb.base/skip1.c +++ b/gdb/testsuite/gdb.base/skip1.c @@ -3,7 +3,7 @@ int bar() return 1; } -int baz(int a, int b) +int baz(int a) { - return a + b; + return a + 1; } -- 1.8.1.4