From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19688 invoked by alias); 7 Jun 2013 15:03:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19677 invoked by uid 89); 7 Jun 2013 15:03:18 -0000 X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 07 Jun 2013 15:03:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r57F38Ox010591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Jun 2013 11:03:09 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r57F36NC008910; Fri, 7 Jun 2013 11:03:07 -0400 Message-ID: <51B1F629.5070006@redhat.com> Date: Fri, 07 Jun 2013 15:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 MIME-Version: 1.0 To: Andreas Arnez CC: gdb-patches@sourceware.org, Ulrich Weigand Subject: Re: [RFA/RFT PATCH 0/3] Add TDB regset support References: <87fvwu5937.fsf@br87z6lw.de.ibm.com> In-Reply-To: <87fvwu5937.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00160.txt.bz2 On 06/07/2013 02:44 PM, Andreas Arnez wrote: > The new z/Architecture introduces restricted hardware transactional > memory with the "transactional-execution facility". Diagnostic > capabilities of this feature include the "program interruption > transaction diagnostic block" (TDB), which is written by the hardware > whenever a transaction is aborted due to a program interruption. > > This patch set makes the TDB accessible from GDB as a new register set. > The first patch reworks the S/390 register map handling without any > functional changes, the second adds the new TDB register set, and the > third implements "dynamic regset" support. > > The third patch changes GDB's approach for enumerating core file > register note sections: Instead of a static array, an iterator function > is now provided by the target-dependent code. This allows for > dynamically selecting a register set for inclusion in a core file > (written with gcore), and making the selection dependent on the current > register values. This is needed for correct treatment of the TDB > register set, because its register values are unavailable when the > inferior was interrupted outside transactions, and then the TDB should > *not* be written into the core file. > > This last patch affects multiple architectures, specifically: > > - GNU/Linux ARM > - GNU/Linux PowerPC > - GNU/Linux S/390 > - GNU/Linux x86 > > In most cases the patch simplifies the target-dependent logic. I've > tested on S/390 and x86 and did not find any regressions. > Why isn't this exposed as a new target description that includes the new register set? -- Pedro Alves