From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31178 invoked by alias); 4 Jun 2013 09:18:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31169 invoked by uid 89); 4 Jun 2013 09:18:44 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 04 Jun 2013 09:18:43 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UjnO5-0007mm-4W from Luis_Gustavo@mentor.com ; Tue, 04 Jun 2013 02:18:41 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 4 Jun 2013 02:18:40 -0700 Received: from [172.30.64.221] ([172.30.64.221]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 4 Jun 2013 02:18:39 -0700 Message-ID: <51ADB0E4.8070601@codesourcery.com> Date: Tue, 04 Jun 2013 09:18:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Will Newton CC: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH, c++ testsuite] Fix a few failures in gdb.cp/virtfunc.exp References: <51AC8CA2.3030008@codesourcery.com> <87vc5vmamh.fsf@fleche.redhat.com> <51ADAAEC.6020902@codesourcery.com> <51ADAD62.6060704@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00038.txt.bz2 On 06/04/2013 11:10 AM, Will Newton wrote: > On 4 June 2013 10:03, Luis Machado wrote: >> On 06/04/2013 10:53 AM, Luis Machado wrote: >>> >>> On 06/03/2013 06:17 PM, Tom Tromey wrote: >>>>>>>>> >>>>>>>>> "Luis" == Luis Machado writes: >>>> >>>> >>>> Luis> 2013-06-03 Luis Machado >>>> Luis> * gdb.cp/virtfunc.exp (make_one_vtable_result): Handle extra >>>> output >>>> Luis> from targets that use function descriptors in the virtual >>>> tables. >>>> >>>> Ok. Thanks for looking at this. >>> >>> >>> Before checking in the patch, i figured out the rest of the problems. >>> >>> Newer GDB's seem to have fixed a problem with displaying thunks in the >>> virtual tables. Older ones did not demangle those names properly. >>> >>> With that said, ppc64 uses dot symbols for those thunks, so we need to >>> account for those in the testcase as well. >>> >>> Here's the updated patch. I escaped dot once (\.) instead of twice. So >>> hopefully this is the correct way. I often get confused with escaping in >>> dejagnu. >>> >>> With this fix, i see only a single failure for virtfunc.exp on ppc64. >>> The other failure is more involved and i'm still chasing the root cause. >> >> >> For convenience, here is an example of how the output looks for ppc64. Thunk >> symbols have a dot prefix. >> >> vtable for 'D' @ 0x10013248 (subobject @ 0x10013ed0): >> [0]: @0x10013c00: 0x10001d64 <.non-virtual thunk to E::vg()> >> [1]: @0x10013ca8: 0x10001eec >> >> vtable for 'V' @ 0x10013290 (subobject @ 0x10013ef0): >> [0]: @0x10013cd8: 0x10001f74 >> [1]: @0x10013c60: 0x10001e38 <.virtual thunk to E::vv()> > > ARM also has a similar problem, as Thumb addresses end up looking like: > > [0]: 0x8e7d > > I'm not sure if it's a problem with the test or if there is a missing > call to addr_bits_remove somewhere. Hum. I'd double check printcmd.c:build_address_symbolic to make sure it is doing the right thing. I think E::vg(), E::vg()+2, E::vg()+3 is what should be displayed, correct? Luis