From: Luis Machado <lgustavo@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>,
"'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH, c++ testsuite] Fix a few failures in gdb.cp/virtfunc.exp
Date: Tue, 04 Jun 2013 09:03:00 -0000 [thread overview]
Message-ID: <51ADAD62.6060704@codesourcery.com> (raw)
In-Reply-To: <51ADAAEC.6020902@codesourcery.com>
On 06/04/2013 10:53 AM, Luis Machado wrote:
> On 06/03/2013 06:17 PM, Tom Tromey wrote:
>>>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:
>>
>> Luis> 2013-06-03 Luis Machado <lgustavo@codesourcery.com>
>> Luis> * gdb.cp/virtfunc.exp (make_one_vtable_result): Handle extra
>> output
>> Luis> from targets that use function descriptors in the virtual
>> tables.
>>
>> Ok. Thanks for looking at this.
>
> Before checking in the patch, i figured out the rest of the problems.
>
> Newer GDB's seem to have fixed a problem with displaying thunks in the
> virtual tables. Older ones did not demangle those names properly.
>
> With that said, ppc64 uses dot symbols for those thunks, so we need to
> account for those in the testcase as well.
>
> Here's the updated patch. I escaped dot once (\.) instead of twice. So
> hopefully this is the correct way. I often get confused with escaping in
> dejagnu.
>
> With this fix, i see only a single failure for virtfunc.exp on ppc64.
> The other failure is more involved and i'm still chasing the root cause.
For convenience, here is an example of how the output looks for ppc64.
Thunk symbols have a dot prefix.
vtable for 'D' @ 0x10013248 (subobject @ 0x10013ed0):
[0]: @0x10013c00: 0x10001d64 <.non-virtual thunk to E::vg()>
[1]: @0x10013ca8: 0x10001eec <D::vd()>
vtable for 'V' @ 0x10013290 (subobject @ 0x10013ef0):
[0]: @0x10013cd8: 0x10001f74 <VB::vvb()>
[1]: @0x10013c60: 0x10001e38 <.virtual thunk to E::vv()>
next prev parent reply other threads:[~2013-06-04 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 12:31 Luis Machado
2013-06-03 16:18 ` Tom Tromey
2013-06-04 8:53 ` Luis Machado
2013-06-04 9:03 ` Luis Machado [this message]
2013-06-04 9:10 ` Will Newton
2013-06-04 9:18 ` Luis Machado
2013-06-05 15:36 ` Tom Tromey
2013-06-05 20:39 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADAD62.6060704@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox