From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10860 invoked by alias); 4 Jun 2013 08:53:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10846 invoked by uid 89); 4 Jun 2013 08:53:44 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 04 Jun 2013 08:53:16 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UjmzR-0005rx-66 from Luis_Gustavo@mentor.com ; Tue, 04 Jun 2013 01:53:13 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 4 Jun 2013 01:53:13 -0700 Received: from [172.30.64.221] ([172.30.64.221]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 4 Jun 2013 01:53:12 -0700 Message-ID: <51ADAAEC.6020902@codesourcery.com> Date: Tue, 04 Jun 2013 08:53:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Tom Tromey CC: "'gdb-patches@sourceware.org'" Subject: Re: [PATCH, c++ testsuite] Fix a few failures in gdb.cp/virtfunc.exp References: <51AC8CA2.3030008@codesourcery.com> <87vc5vmamh.fsf@fleche.redhat.com> In-Reply-To: <87vc5vmamh.fsf@fleche.redhat.com> Content-Type: multipart/mixed; boundary="------------020900020506010801030408" X-Virus-Found: No X-SW-Source: 2013-06/txt/msg00034.txt.bz2 This is a multi-part message in MIME format. --------------020900020506010801030408 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 995 On 06/03/2013 06:17 PM, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado writes: > > Luis> 2013-06-03 Luis Machado > Luis> * gdb.cp/virtfunc.exp (make_one_vtable_result): Handle extra output > Luis> from targets that use function descriptors in the virtual tables. > > Ok. Thanks for looking at this. Before checking in the patch, i figured out the rest of the problems. Newer GDB's seem to have fixed a problem with displaying thunks in the virtual tables. Older ones did not demangle those names properly. With that said, ppc64 uses dot symbols for those thunks, so we need to account for those in the testcase as well. Here's the updated patch. I escaped dot once (\.) instead of twice. So hopefully this is the correct way. I often get confused with escaping in dejagnu. With this fix, i see only a single failure for virtfunc.exp on ppc64. The other failure is more involved and i'm still chasing the root cause. Luis --------------020900020506010801030408 Content-Type: text/x-patch; name="virtfunc_fix.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="virtfunc_fix.diff" Content-length: 732 2013-06-04 Luis Machado * gdb.cp/virtfunc.exp (make_one_vtable_result): Handle extra output from targets that use function descriptors in the virtual tables. Handle presence of dot symbols. diff --git a/gdb/testsuite/gdb.cp/virtfunc.exp b/gdb/testsuite/gdb.cp/virtfunc.exp index 2509cc7..1c2268a 100644 --- a/gdb/testsuite/gdb.cp/virtfunc.exp +++ b/gdb/testsuite/gdb.cp/virtfunc.exp @@ -234,7 +234,7 @@ proc make_one_vtable_result {name args} { set result "vtable for '${name}' @ $hex .subobject @ $hex.:$nls" set count 0 foreach func $args { - append result ".${count}.: $hex <$func..>${nls}" + append result ".${count}.:( @$hex:)? $hex <(\.)?$func..>${nls}" incr count } --------------020900020506010801030408--