From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: RFC: introduce scoped cleanups
Date: Fri, 31 May 2013 16:15:00 -0000 [thread overview]
Message-ID: <51A8CC81.9070509@redhat.com> (raw)
In-Reply-To: <87obbrp2hg.fsf@fleche.redhat.com>
On 05/31/2013 04:56 PM, Tom Tromey wrote:
>>> Pedro said he was interested in general stack-based allocation of
>>> cleanups, so I implemented that, following his plan.
>
> Joel> Is this purely for performance?
>
> Yeah, I think so.
Yeah, like, Tom, I've occasionally found myself sometimes
considering avoiding cleanups, avoiding the heap allocations,
in cases performance may matter. Clearly we're not alone, as
evidenced from several of Tom's patches exposing spots where
we were avoiding having a "master" cleanup, some times using
tricky conditionals. I had thought of this stack cleanups
scheme before, but never actually went through with it. Seeing
Tom's scope cleanups were already stack based and most of the
way there, made me feel that it'd be a pity to be able to have
stack-based cleanups, but then as soon as you need a real cleanup
that does actual cleanup (as opposed to null_cleanup), you still
need to get back to install a heap cleanup anyway.
--
Pedro Alves
next prev parent reply other threads:[~2013-05-31 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 18:56 Tom Tromey
2013-05-30 20:09 ` Tom Tromey
2013-05-31 6:11 ` Joel Brobecker
2013-05-31 15:56 ` Tom Tromey
2013-05-31 16:15 ` Pedro Alves [this message]
2013-05-31 20:24 ` Tom Tromey
2013-06-03 6:07 ` Joel Brobecker
2013-06-05 17:44 ` Tom Tromey
2013-07-16 20:33 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A8CC81.9070509@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox