From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29177 invoked by alias); 31 May 2013 09:40:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29166 invoked by uid 89); 31 May 2013 09:40:18 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 31 May 2013 09:40:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4V9eD0L030088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 31 May 2013 05:40:13 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4V9e5AL009456; Fri, 31 May 2013 05:40:06 -0400 Message-ID: <51A86FF5.9090401@redhat.com> Date: Fri, 31 May 2013 09:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Doug Evans CC: Keith Seitz , brobecker@adacore.com, psmith@gnu.org, gdb-patches@sourceware.org Subject: Re: [patch] Improve symbol lookup performance noted in PR 15519 References: <20903.57436.871210.593441@ruffy.mtv.corp.google.com> In-Reply-To: <20903.57436.871210.593441@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg01102.txt.bz2 On 05/31/2013 12:27 AM, Doug Evans wrote: > Hi. > Here's the patch I intend to check in to "fix" > http://sourceware.org/bugzilla/show_bug.cgi?id=15519 > [It's not a complete "fix", there's still some performance gains > to be had, but I'm leaving that for a separate pass. This gets > us >95% of the way there, at least in the benchmarks I've been using, > including the one in the PR. Thanks Paul!] > > No regressions on amd64-linux, with/without Fission. > > I'll let it sit for a few days in case there are any more comments. > I'd also like to commit this to the 7.6 branch. Ok Joel? > [I need to rerun the testsuite in that tree before committing there.] Thanks! Absolutely no objections, but for my own education, and for the archives, could you describe the gist of it? E.g., what is it that is slow, and what is it that is being avoided to get the speedup? (where's the win?) It isn't super obvious to me from reading the patch. -- Pedro Alves