Re: [PATCH 01/22] [GDBserver] Multi-process + multi-arch: core + GNU/Linux x86*

[Pedro Alves <palves@redhat.com>]

On 05/29/2013 08:03 PM, Tom Tromey wrote:
> Pedro> diff --git a/gdb/gdbserver/linux-amd64-ipa.c b/gdb/gdbserver/linux-amd64-ipa.c
> Pedro> index dc20a15..d0c40c9 100644
> Pedro> --- a/gdb/gdbserver/linux-amd64-ipa.c
> Pedro> +++ b/gdb/gdbserver/linux-amd64-ipa.c
> Pedro> @@ -23,6 +23,9 @@
> Pedro>  /* Defined in auto-generated file amd64-linux.c.  */
> Pedro>  void init_registers_amd64_linux (void);
>  
> Pedro> +/* Ditto.  */
> Pedro> +extern struct target_desc *tdesc_amd64_linux;
> 
> It seems like this (and other instances) could be const.

Good idea.

While at it, I noticed the since the globals in the generated
files, are now accessed through the target_desc globals, can/should
be made static:

-const char *expedite_regs_tilegx[] = { "sp", "lr", "pc", 0 };
-const char *xmltarget_tilegx = 0;
+static const char *expedite_regs_tilegx[] = { "sp", "lr", "pc", 0 };
+static const char *xmltarget_tilegx = 0;

I did the necessary change to regdat.sh.

> Pedro>  struct reg *
> Pedro> -find_register_by_name (const char *name)
> Pedro> +find_register_by_name (struct target_desc *tdesc, const char *name)
> 
> How about const here?
> 
> Pedro>  int
> Pedro> -find_regno (const char *name)
> Pedro> +find_regno (struct target_desc *tdesc, const char *name)
> 
> And here and other similar spots?

Yes, a bunch of other spots.  :-)

Did the adjustment now across the whole series.
Good old grep is telling I didn't miss any spot.

> Pedro> +struct target_desc
> Pedro> +{
> Pedro> +  /* An array of NUM_REGISTERS elements of register definitions that
> Pedro> +     description the inferior's register set.  */
> Pedro> +  struct reg *reg_defs;
> 
> I think it should be "...that describe...".

Indeed.  Thanks!

v3 coming up...

-- 
Pedro Alves