From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31663 invoked by alias); 30 May 2013 09:23:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31647 invoked by uid 89); 30 May 2013 09:23:41 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 09:23:40 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Uhz58-0000PL-BH from Yao_Qi@mentor.com ; Thu, 30 May 2013 02:23:38 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 30 May 2013 02:23:38 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Thu, 30 May 2013 02:23:37 -0700 Message-ID: <51A71ABA.6080402@codesourcery.com> Date: Thu, 30 May 2013 09:23:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH 15/40] make a cleanup unconditionally in tracepoint.c References: <568e3554958cb42488bc51f5e2bd8b5cd817803c.1368124285.git.tromey@redhat.com> In-Reply-To: <568e3554958cb42488bc51f5e2bd8b5cd817803c.1368124285.git.tromey@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-05/txt/msg01049.txt.bz2 On 05/10/2013 02:51 AM, Tom Tromey wrote: > This is another cosmetic patch. It introduces an "outer" cleanup in > trace_dump_command and arranges to unconditionally call do_cleanups. > This lets the checker analyze the function. > > * tracepoint.c (trace_dump_command): Unconditionally call > do_cleanups. Tom, this patch looks right to me. I'd like to know your plan on these patches, will you commit them recently? I ask this because I have a patch touches the same place as yours, and I've picked up this patch in my tree. -- Yao (齐尧)