From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3981 invoked by alias); 30 May 2013 09:02:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3939 invoked by uid 89); 30 May 2013 09:02:47 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 30 May 2013 09:02:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4U92iMu004624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 30 May 2013 05:02:44 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4U92g8w028425; Thu, 30 May 2013 05:02:43 -0400 Message-ID: <51A715B2.3050302@redhat.com> Date: Thu, 30 May 2013 09:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove parameter 'struct breakpoint *t' of encode_actions and encode_actions_1 References: <1369895749-17590-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1369895749-17590-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg01046.txt.bz2 On 05/30/2013 07:35 AM, Yao Qi wrote: > Functions encode_actions_1 and encode_actions pass both 'bp_location' > and 'breakpoint' in parameters, but the latter can be retrieved from > the former. The latter one can be removed. The patch is somewhat > obvious, and review still is welcome. Regression tested on > x86_64-linux. OK. Thanks, -- Pedro Alves