From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6629 invoked by alias); 29 May 2013 18:51:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6619 invoked by uid 89); 29 May 2013 18:51:19 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 18:51:19 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TIpILF010248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 14:51:18 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4TIpGAY022483; Wed, 29 May 2013 14:51:17 -0400 Message-ID: <51A64E24.2020901@redhat.com> Date: Wed, 29 May 2013 18:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [RFA 5/7 take 2] Improved linker-debugger interface References: <20130516144340.GA2105@blade.nx> <20130516144838.GF2105@blade.nx> <20130517185002.GA10447@host2.jankratochvil.net> <20130524083044.GC4602@blade.nx> In-Reply-To: <20130524083044.GC4602@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg01032.txt.bz2 On 05/24/2013 09:30 AM, Gary Benson wrote: > +static int > +svr4_update_solib_event_breakpoint (struct breakpoint *b, void *arg) > +{ > + struct svr4_info *info = get_svr4_info (); > + struct bp_location *loc; > + ... > + for (loc = b->loc; loc; loc = loc->next) > + { > + struct probe_and_action *pa = solib_event_probe_at (info, loc->address); There's no relation between INFO and the locations' inferior/program space. IOW, I believe this is doing the wrong thing for multi-process. > + for (tail = info->solib_list; tail->next; tail = tail->next) tail->next != NULL > + for (loc = b->loc; loc; loc = loc->next) loc != NULL. > + if (!strcmp (name,"rtld_map_failed")) strcmp (name,"rtld_map_failed") == 0 There may be other instances in your patches. It'd be nice to have them fixed. Otherwise, looks about ready to me too (with Jan's comments addressed). -- Pedro Alves