From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-102025-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3452 invoked by alias); 29 May 2013 18:50:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 3409 invoked by uid 89); 29 May 2013 18:50:25 -0000
X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 18:50:25 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4TIoOiU006968	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Wed, 29 May 2013 14:50:24 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4TIoMNH010237;	Wed, 29 May 2013 14:50:23 -0400
Message-ID: <51A64DEE.6070307@redhat.com>
Date: Wed, 29 May 2013 18:50:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4
MIME-Version: 1.0
To: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 3/7 take 2] New gdbserver functionality
References: <20130524074613.GA4602@blade.nx>
In-Reply-To: <20130524074613.GA4602@blade.nx>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-05/txt/msg01031.txt.bz2

On 05/16/2013 03:48 PM, Gary Benson wrote:

> +	  sep = strchr (annex, '=');
> +	  if (!sep)

Please write

         if (sep == NULL)

There are more instances of this in the patch.

> +	    break;
> +
> +	  len = sep - annex;
> +	  if (len == 5 && !strncmp (annex, "start", 5))

strncmp does not return a boolean.  Please write:

> +	  if (len == 5 && strncmp (annex, "start", 5) == 0)


> +	  else if (len == 4 && !strncmp (annex, "prev", 4))

Ditto.

Otherwise looks good to me too.

There should be a NEWS entry for the new RSP feature too though.

-- 
Pedro Alves