From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12079 invoked by alias); 29 May 2013 17:18:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12025 invoked by uid 89); 29 May 2013 17:18:02 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_BJ autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 17:18:01 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4THI0pe019574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 May 2013 13:18:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4THHwih006923; Wed, 29 May 2013 13:17:59 -0400 Message-ID: <51A63846.70905@redhat.com> Date: Wed, 29 May 2013 17:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: gdb-patches@sourceware.org, Gary Benson CC: Tom Tromey Subject: Re: [RFA 2/7 take 2] API for inhibiting section map updates References: <20130516144340.GA2105@blade.nx> <20130516144813.GC2105@blade.nx> <87mwrpohnv.fsf@fleche.redhat.com> <20130524074737.GB4602@blade.nx> In-Reply-To: <20130524074737.GB4602@blade.nx> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg01027.txt.bz2 On 05/24/2013 08:47 AM, Gary Benson wrote: > /* Update the table in exec_ops, used to read memory. */ > ALL_OBJFILE_OSECTIONS (objfile, s) > @@ -1291,11 +1300,14 @@ static void > update_section_map (struct program_space *pspace, > struct obj_section ***pmap, int *pmap_size) > { > + struct objfile_pspace_info *pspace_info; > int alloc_size, map_size, i; > struct obj_section *s, **map; > struct objfile *objfile; > > - gdb_assert (get_objfile_pspace_data (pspace)->objfiles_changed_p != 0); > + pspace_info = get_objfile_pspace_data (current_program_space); Shouldn't this be 'pspace' instead of 'current_program_space'? > + gdb_assert (pspace_info->section_map_dirty != 0 > + || pspace_info->new_objfiles_available != 0); > -- Pedro Alves