From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27217 invoked by alias); 29 May 2013 16:02:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27207 invoked by uid 89); 29 May 2013 16:02:32 -0000 X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,SPF_PASS autolearn=ham version=3.3.1 Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 16:02:31 +0000 Received: from EUSAAHC005.ericsson.se (Unknown_Domain [147.117.188.87]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id B2.F1.05617.69626A15; Wed, 29 May 2013 18:02:30 +0200 (CEST) Received: from eusaamw0711.eamcs.ericsson.se (147.117.20.178) by EUSAAHC005.ericsson.se (147.117.188.87) with Microsoft SMTP Server (TLS) id 14.2.328.9; Wed, 29 May 2013 12:02:29 -0400 Received: from [142.133.110.167] (147.117.20.214) by smtps-am.internal.ericsson.com (147.117.20.178) with Microsoft SMTP Server (TLS) id 8.3.279.1; Wed, 29 May 2013 12:02:29 -0400 Message-ID: <51A6263A.9080104@ericsson.com> Date: Wed, 29 May 2013 16:02:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Eli Zaretskii CC: , Subject: Re: [PATCH v2] Exit code of exited inferiors References: <51A5160D.40800@ericsson.com> <83k3mh6ant.fsf@gnu.org> In-Reply-To: <83k3mh6ant.fsf@gnu.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg01000.txt.bz2 On 13-05-29 11:57 AM, Eli Zaretskii wrote: >> Date: Tue, 28 May 2013 16:39:41 -0400 >> From: Simon Marchi >> CC: Marc Khouzam >> >> This is the second version of my patch to add the exit-code in the >> -list-thread-groups output. New in v2: NEWS file, documentation and a >> test case. I didn't find any test about -list-thread-groups so I created it. >> >> As far as I know, this does not break any other test. >> >> Changelog: >> >> 2013-05-28 Simon Marchi >> >> * gdb/NEWS: Announce new exit-code field. >> * gdb/doc/gdb.texinfo: Document new exit-code field. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > You should state the name of the node in which you made the change, as > if it were a function (i.e. in parentheses). > >> * gdb/inferior.c (exit_inferior_1): Remove exit code clear. >> (inferior_appeared): Add exit code clear. >> * gdb/mi/mi-main.c (print_one_inferior): Add printing of the exit code. >> * gdb/testsuite/gdb.mi/mi-list.exp: New file, added test case for >> -list-thread-groups. > OK for the documentation part, after you have fixed the above gotcha. > > Thanks. Marc Khouzam made me realize that there is a specific ChangeLog in gdb/doc, so I guess any change in that folder should go in this ChangeLog, is that right? Same thing for gdb/testsuite. Simon