From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15512 invoked by alias); 29 May 2013 12:11:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15484 invoked by uid 89); 29 May 2013 12:11:53 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 29 May 2013 12:11:53 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UhfEK-0000Kz-Rx from Luis_Gustavo@mentor.com ; Wed, 29 May 2013 05:11:48 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 29 May 2013 05:11:48 -0700 Received: from [172.30.64.149] ([172.30.64.149]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 29 May 2013 05:11:48 -0700 Message-ID: <51A5F07A.6090005@codesourcery.com> Date: Wed, 29 May 2013 12:11:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: "Blanc, Nicolas" CC: "gdb-patches@sourceware.org" , "palves@redhat.com" , "tromey@redhat.com" , "eliz@gnu.org" , "yao@codesourcery.com" Subject: Re: [patch v4 1/3] Create remove-symbol-file command. References: <1369818805-14288-1-git-send-email-nicolas.blanc@intel.com> <1369818805-14288-2-git-send-email-nicolas.blanc@intel.com> <51A5CC72.2090000@codesourcery.com> <388084C8C1E6A64FA36AD1D656E485661A799D20@IRSMSX106.ger.corp.intel.com> In-Reply-To: <388084C8C1E6A64FA36AD1D656E485661A799D20@IRSMSX106.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00993.txt.bz2 Hi, On 05/29/2013 02:08 PM, Blanc, Nicolas wrote: > Hi Luis, > > Thanks for your feedback. I'll fix the nits. > >> I'm thinking, with a command called "remove-symbol-file" i would expect to provide some kind of filename to this command. Should the user also be able to state a DSO name here and have it unloaded? >> Maybe have the name translated to the base address used to unload the library internally? > > The first address parameter of the add-symbol-file command is a better way to identify the file to remove than the file name because a file can be loaded multiple times at different addresses -- this case is important for me. The user knows the "start address" very well since he typed it in for adding the file. So I see no real benefit of adding a file-name parameter. I see. That was mostly a suggestion. If it problematic to implement it that way, then i suppose it is OK to use solely the base address. > > Keeping the current syntax would be ok with you? Sure, that looks good to me.