From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14482 invoked by alias); 24 May 2013 08:11:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14426 invoked by uid 89); 24 May 2013 08:11:02 -0000 X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KAM_TIME,KHOP_RCVD_UNTRUST,KHOP_THREADED,MISSING_HEADERS,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=no version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 24 May 2013 08:11:02 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1Ufn5Y-0007HK-Iz from Luis_Gustavo@mentor.com ; Fri, 24 May 2013 01:11:00 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by svr-orw-fem-01.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 24 May 2013 01:10:59 -0700 Received: from [172.30.64.161] ([172.30.64.161]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 24 May 2013 01:10:50 -0700 Message-ID: <519F2084.3090104@codesourcery.com> Date: Fri, 24 May 2013 08:11:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 CC: Edjunior Barbosa Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix wp-replication.exp for targets that provide only 1 hw watchpoint References: <1369365909-14746-1-git-send-email-emachado@linux.vnet.ibm.com> <519F17A0.2040607@codesourcery.com> In-Reply-To: <519F17A0.2040607@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00913.txt.bz2 On 05/24/2013 09:32 AM, Luis Machado wrote: >> current wp-replication.exp testcase counts 2 hw watchpoints even when >> the target >> provides only 1 hw watch, resulting in several unexpected errors. >> Successfully >> tested on x86 (with 4 hw watchpoints available) and ppc64 server (with >> 1 hw >> watch), this patch intends to fix this issue. Ok? > > I wonder why it is counting one more watchpoint. Is it not matching the > output in the exit block here? I think i see the problem here. "break" only really jumps out of the gdb_test_multiple block instead of breaking, so this would be a problem for all targets that do "on the fly" accounting of resources, thus not taking the error check leg of the test. Maybe replace both "break" with "continue". We really just want to reach the top of the while loop here to either jump out of the loop or continue with it. What do you think? Luis