Re: [PATCH] Fix wp-replication.exp for targets that provide only 1 hw watchpoint

Edjunior Barbosa Machado
2013-05-24T14:03:33Z

On 05/24/2013 05:10 AM, Luis Machado wrote:
> I think i see the problem here. "break" only really jumps out of the
> gdb_test_multiple block instead of breaking, so this would be a problem
> for all targets that do "on the fly" accounting of resources, thus not
> taking the error check leg of the test.

Thanks Luis for the feedback, I think you've narrowed down the problem.
That happens on targets that do 'on the fly' checking of available
watchpoints (like ppc64 does). It's not a matter of number of available
hw watchpoints as my original message suggests.

> Maybe replace both "break" with "continue". We really just want to reach
> the top of the while loop here to either jump out of the loop or
> continue with it.

'continue' doesn't work either. From what I understood, 'break' or
'continue' will terminate the iteration of the innermost nested loop,
that seems to be the gdb_test_multiple block. That's why it continues to
the second gdb_test_multiple block and wrongly increments hwatch_count
instead of going to the beginning of while block.

--
Edjunior