Re: [PATCH] Fix wp-replication.exp for targets that provide only 1 hw watchpoint

Luis Machado
2013-05-24T08:11:10Z

On 05/24/2013 09:32 AM, Luis Machado wrote:
>> current wp-replication.exp testcase counts 2 hw watchpoints even when
>> the target
>> provides only 1 hw watch, resulting in several unexpected errors.
>> Successfully
>> tested on x86 (with 4 hw watchpoints available) and ppc64 server (with
>> 1 hw
>> watch), this patch intends to fix this issue. Ok?
>
> I wonder why it is counting one more watchpoint. Is it not matching the
> output in the exit block here?

I think i see the problem here. "break" only really jumps out of the
gdb_test_multiple block instead of breaking, so this would be a problem
for all targets that do "on the fly" accounting of resources, thus not
taking the error check leg of the test.

Maybe replace both "break" with "continue". We really just want to reach
the top of the while loop here to either jump out of the loop or
continue with it.

What do you think?

Luis