From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26858 invoked by alias); 23 May 2013 17:46:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26847 invoked by uid 89); 23 May 2013 17:46:03 -0000 X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 23 May 2013 17:46:02 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4NHk0V2032163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 23 May 2013 13:46:00 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4NHjwhJ012073; Thu, 23 May 2013 13:45:59 -0400 Message-ID: <519E55D6.2010602@redhat.com> Date: Thu, 23 May 2013 17:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 0/5 V3] target-assisted range stepping References: <20130514191026.13213.39574.stgit@brno.lan> <519D6AB0.1070108@codesourcery.com> In-Reply-To: <519D6AB0.1070108@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00887.txt.bz2 On 05/23/2013 02:02 AM, Yao Qi wrote: > On 05/15/2013 03:10 AM, Pedro Alves wrote: >> It took a while, but finally here's my take on the range stepping >> series. This is based on Yao's v1 and v2 series, so I'm calling it >> v3. The gist of the feature is the same, although the implementation >> in both GDB and GDBserver is a different. > > Pedro, > I go through this series, and give some comments on patch 3/5, 4/5, and 5/5. With my addition on patch 5/5 (skip test earlier if it fails), it works well on my stub. Thanks for refining the range stepping series. Great! I'm now applied the series, after addressing your comments. Tested on Fedora 17, native and gdbserver. Thanks, -- Pedro Alves