From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1730 invoked by alias); 23 May 2013 00:56:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1720 invoked by uid 89); 23 May 2013 00:56:34 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 23 May 2013 00:56:34 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UfJpY-0005MY-U5 from Yao_Qi@mentor.com ; Wed, 22 May 2013 17:56:32 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 22 May 2013 17:56:32 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Wed, 22 May 2013 17:56:32 -0700 Message-ID: <519D6954.80006@codesourcery.com> Date: Thu, 23 May 2013 00:56:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Subject: Re: [PATCH 4/5] range stepping: gdbserver (x86 GNU/Linux) References: <20130514191026.13213.39574.stgit@brno.lan> <20130514191054.13213.58686.stgit@brno.lan> In-Reply-To: <20130514191054.13213.58686.stgit@brno.lan> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-05/txt/msg00864.txt.bz2 On 05/15/2013 03:10 AM, Pedro Alves wrote: > @@ -2063,9 +2067,22 @@ handle_v_cont (char *own_buf) > goto err; > resume_info[i].sig = gdb_signal_to_host (sig); > } > + else if (p[0] == 'r') > + { > + char *p1; > + > + p = p + 1; > + p1 = strchr (p, ','); > + decode_address (&resume_info[i].step_range_start, p, p1 - p); > + > + p = p1 + 1; > + p1 = strchr (p, ':'); > + decode_address (&resume_info[i].step_range_end, p, p1 - p); > + > + p = p1; > + } > else > { > - resume_info[i].sig = 0; What is the purpose to remove this line? > p = p + 1; > } The patch looks good to me. > So in the end, seeing how all was always in the target, I just went with > leaving the fields Linux specific, rather than leave the fields dangling on > other targets, thinking it'd be easy enough to reconsider once other > targets implement range stepping. Meanwhile, other targets wouldn't > pay for extra fields they don't use. OK, that is fine to me. -- Yao (齐尧)