From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22780 invoked by alias); 23 May 2013 00:47:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22770 invoked by uid 89); 23 May 2013 00:47:03 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 23 May 2013 00:47:02 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UfJgJ-0004sY-EE from Yao_Qi@mentor.com ; Wed, 22 May 2013 17:46:59 -0700 Received: from SVR-ORW-FEM-03.mgc.mentorg.com ([147.34.97.39]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Wed, 22 May 2013 17:46:58 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.2.247.3; Wed, 22 May 2013 17:46:58 -0700 Message-ID: <519D6717.4000203@codesourcery.com> Date: Thu, 23 May 2013 00:47:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: Eli Zaretskii , Subject: Re: [PATCH 3/5] range stepping: gdb References: <20130514191026.13213.39574.stgit@brno.lan> <20130514191047.13213.8476.stgit@brno.lan> <83k3n173ao.fsf@gnu.org> <5193621C.50603@redhat.com> <83ppws5w00.fsf@gnu.org> <519381E9.3020007@redhat.com> <83bo8c5pb7.fsf@gnu.org> <5193948A.9090609@redhat.com> <5193D1FE.9070804@redhat.com> <83sj1n4fum.fsf@gnu.org> <519A6EC1.6070306@redhat.com> In-Reply-To: <519A6EC1.6070306@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-05/txt/msg00863.txt.bz2 On 05/21/2013 02:43 AM, Pedro Alves wrote: > diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h > index a9f8a94..e93b965 100644 > --- a/gdb/gdbthread.h > +++ b/gdb/gdbthread.h > @@ -65,6 +65,13 @@ struct thread_control_state > CORE_ADDR step_range_start; /* Inclusive */ > CORE_ADDR step_range_end; /* Exclusive */ > > + /* If GDB issues a target step request, and this is nonzero, the > + target should single-step this thread once, and then continue > + single-stepping it without GDB involvement as long as thread ^^^ Nit: How about "GDB core"? Since we didn't treat range stepping as remote-specific, so other targets, such as native target, may implement range stepping, and it is part of GDB. This patch looks good to me. -- Yao (齐尧)