From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11564 invoked by alias); 22 May 2013 10:14:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11545 invoked by uid 89); 22 May 2013 10:14:08 -0000 X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 22 May 2013 10:14:08 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4MAE28E029530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 May 2013 06:14:03 -0400 Received: from [10.36.6.14] (vpn1-6-14.ams2.redhat.com [10.36.6.14]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4MADxiE019978 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 22 May 2013 06:14:01 -0400 Message-ID: <519C9A46.4010302@redhat.com> Date: Wed, 22 May 2013 10:14:00 -0000 From: nick clifton User-Agent: Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17.1 MIME-Version: 1.0 To: Mike Frysinger , binutils@sourceware.org CC: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [RFC] msp430 instruction decoder References: <20130516150246.2463f977@mesquite.lan> <201305171354.20292.vapier@gentoo.org> In-Reply-To: <201305171354.20292.vapier@gentoo.org> Content-Type: multipart/mixed; boundary="------------000502080708060603080000" X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00819.txt.bz2 This is a multi-part message in MIME format. --------------000502080708060603080000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1524 Hi Mike, This patch was created by DJ, but he is on vacation so Kevin was asked to submit it on his behalf. Now I am wading in to address the points that you raised... > typically it's better to omit generated files from patches posted to the list. > it's often times a lot of noise (like in this case). Agreed - I have done so in the revised patch attached to this email. > missing standard copyright/license block Added. >> +typedef struct >> +{ >> + MSP430_Opcode_Decoded * msp430; > > shouldn't the style be: > MSP430_Opcode_Decoded *msp430; > seems like general style guidelines are violated a lot in this file. do we > normally ignore that in the opcodes/ tree ? No, and I have revised the formatting in the patch files. They do now conform to the GNU Coding Standard. Note - the msp430-decode.opc file includes some comments that do not quite conform to the standard. This is because these comments are directives to the opc2c program and need to remain in their current format. Do you have any more concerns with this patch ? Cheers Nick opcodes/ChangeLog * msp430-decode.opc: New. * msp430-decode.c: New/generated. * Makefile.am (TARGET_LIBOPCODES_CFILES): Add msp430-decode.c. (MAINTAINER_CLEANFILES): Likewise. Add rule to build msp430-decode.c frommsp430decode.opc using the opc2c program. * Makefile.in: Regenerate. * configure.in: Add msp430-decode.lo to msp430 architecture files. * configure: Regenerate. include/opcode/ChangeLog * msp430-decode.h: New. --------------000502080708060603080000 Content-Type: application/x-bzip; name="msp430-opcodes-dis.patch.bz2" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="msp430-opcodes-dis.patch.bz2" Content-length: 7996 QlpoOTFBWSZTWRZ4Y4MAFgpfgHy5X//////33/+//9//YBv97PinBu073rZ7 HdW3CcVzGt17d3p3rue9tde60iZpXTavdXNe5sjShWug0pIK6FAL3d1JpbB2 51TMW0tBrVbuwlNJACNBkp7IKnmKY1TaGp6T1PUepkbRGmjI0Mj1NA0aBJEB AE0TEypvST0aUe9U8iTxTxTaJk00aaHqaaGgDJ6QcDTTTQaGhoZGgGQBoaA0 0ZAAAwmIDQSaUSAQEwk9BlM1TT1PU9T0h5Q9QGgPU0AAAAAiSiaKD1Gg9TRp oDT1GmmgPUAAaAaaaHqA9I0AEiIQE0JpiaCaaNU8KeFTeian6mJlPT0mIyh7 SJ6T1Bo9EfBOsOkp2YKpKyTjd8zgwyQPfRJZJAsUkUCS1CrxmtTNzjM+xgmi heowxfa2lLt+FcTQlbgJGHlSTMwQaPfufiyjyG1GHqX41K22f9aOyCRAUKab ShCxMzsmG6fR1+e47D8/ZXiwO+Abzo1dINoGxQCNzRvNn8JW84FjM4RABm0V CygPoaiW7SpO1hQGm5Be8Ju5IkXfzrD6b7HpNpfjSL2da7/zr7aDOBIwG6f3 kAoUIoDBsCcP3TDjeLq60NyFEZRS7ovdnGQhp+iR4e54IrDjnqlLSCjIiKEz aIHRG6PV9X36V8Sy46/ylFhlTSsfmU5LoX4zQuORtE2gbQDabEQgvSnOk9Of Y+3XpqVUbvMIiyW1mNfDeacVkvfv5/i7PZw2fn2yHZBYQwcnCCmIRZK21DNx MLiWsMZcnImJiizQSYQUJMWyANyXAmUc4YMK47eGh4Ayqp6LU4dvHiZWPb3d 2Gl6t1K6kkmI9fVEoiBhkz6ozLpO6bE2QEZVItcOGLHZJgLKuR3eBomqX2k9 HuOIjYETniD4E4EGkSDAZBQY2KCJXqZBZCKIyBESQWPMNUUBEBvTkwEAxEQE kRbqxgVFWIlzEAYjTRSBEGRBDz3qR5kFtTXLOLDGySD7q9XwvyU7dIjbM18C 9KYDGJoDLd/0NnnlSJZh34mXkJHnR7eUw8sSXoB2Qydre1IXIncMe/sMt1jj 6BUUfsfKMx+nZzVAekKJy9VKFatfCats1uawgUKIz+1tSwkFJ69tFVgqbI3l mZgdcnJf7N337sw7R84t1OqfM/8GFwDYjnYrlx6CszFzR8YyrZpEB3EFma/d lYxsZRG6lm7qxNYXykCMr5T199HC0rIzKa64nEszzeuo7h/gijlwJnyblwVm Q4Cxr3m2N8fePdEYratVVgBTrMZKJ5ZEEMe7jy+S4OdgJ9jlERM3bbS22Vhw eTkbjxo0RraDzi8EGfrp/Sm6x7S7Vo9cQOGRnoVkpVw4dUZi1ZpNgZ4wVUpC 1PDaTqKYcMX5j+BFUKgNJldC+9LCbOlNp+F1DWOi8aqiM/LP9pr7BX7Pq3Y7 rvoYgkSM1pawugbllDUeDuwm+B5/e+Tj34YlNmkJkvkkwJChzgCPniit2WQ3 3YAVjbrwWJR+a0v3m97L43gVV+KrNFKp6Sho9XvGobee3wNta48hjEvsd0L+ 14zb5tDunpEcPJOlZ9B6beqDViYHH1lKUgQPt2feXks6zvL0jtPhPyloaDGQ x6c36mSyF143oSjsG3C9KTyWQfPDGA1fMv3+L3aQNXittttttttttttpbS3f jGLbbaW22222o2/cxNuQ24DCq0UFRGoqhTFnhlMcJ3ieYfrke0368dr270TN hSJS20pRCsmMdfJ5erOs1RorCHWa4wENmOfUXLtlLfyYxZDt9ANSJ3ZE9dUW z8tYprmbu0IeDb9c4nXteBgvZfAvky1FuGGjyMqXcD53KaOaClKQDSzB3jxB EFQZzKJe0ph/HAY7vJvoIr+siLNdJlTQl6eiu8jqFtGHJXJoi4ufbHJheSWo fvjpCSuhQECEU1xiMAaB56msrm5WM7laKsJoPLTZ8rnnL04yudNpll8Xr01F i7MvNJKnQdvmiX9loZ7sDwRXKQCbe06fSkkkCgmdQW2OjNH91Wp9sKsA6E1z zTM1NSUo1cNYdchDNDB6/E0arvI3pq0xiQ/tOh0cv5uFsNtgSswQZZk12zQG +Y8ZOrXrue5jI9tNeFME09xP1ZcOLu7Y6gyzrcaj8bPDQ79meeovsoEmGdDG Q0idhsHLvAeTRCKLEnVNmsOg+Ai5LLxORz9/LUB8O6/mkuHsmW6GI9PHgB6D fsVRfHaT0UmtYgh+3oMEUg2V47M2ANbcU9OSSg2RzlOuYc26iHntygQHQmmN rc7xgHBYU2izLLGJQvMzYaSKliqQBpsQVroAV5IP3CLVqAV471oLmxgqBcat /4yj3EYAKTPgCzDFHhZWL0geLwYhO4SFT1QEuGlKs8uVEWBoGwXs9UG/SEFt 36yRDUQ3MkSnaSKuTDCU942KtIBpxv4KNIkP7sIG5A/2ge/bZ8n1mh9s59N7 kk3oG4IbxOAM3YmB6ZUiuXnObuOdR2KHZ18XY5zgymi80D9KKRnDuJv7Tz9U Za27iHpRREUmSZ92zus3QdxZ8WMome+hm2vdj67ctWFdX1SAcXeVvV7nJsTy jmYdmmreG4ERYKn29ftmN+Tjc5jCZ5b/pjZffOdaROAFwzsmW5QaSvloUMnC YwZw3dXR8nvwHamspNFeHiiaZ1efjPP+2iKwApZIFQi8s7erQNA0QirA8gWE JpEXGSRVC4gki5LyihCkEBkdxSwG2BBDu3b8nN2a5DVrz8XlUmMszxZ7c8M0 aFKo+1Tiivvis0W6FKuF/RFOsMc9bx2dbltO3KRcWoTRtyybPC7ymD95QNga XlZvuwbbG7JlMLx2gbTqU114XlcH88HJ92JdbUV1Rg5G+OWudNWY5ZZZ7Y6r nUjAtXj6G2/S7xwHZH58LSV6+a+XR4gO4Jjhw7McIlUFeWFAaEFuGwHiBt6G n6dEtsrr4fgFRBYRzMGJoAbG0mkwEeD18Sx173k8tBmGZDDTJzpEI3S/CMu/ Sk7ZEbXrUspWk1mFIwk6p8cdu0uMHZs+elo+Odz0tukqpmHjS8+/xfohFTLz wzeMfAqzacfE0Ym4/CN1Z2ZZC1jnTaR05VgdeGStDprHpmsz5t3K+qL1hfHB zMTBRyNMIQzNHpAkOSTpSMRFiqKgx62wjADQOCYHBwKEHPMeQjaXEhOTH3iA +/ptgvFz55yM1QJnxudaqq9n9AzDBkRM/p2GGDuzq9NW4YOAgLiUhCsMZ+2f KSICsi7Zhub6XbsWkA0m7V8YJIXCi0hkCqtgf5bnXryevXJu10UU0Gj7Q1SU mFlhrkHBdRT1wE5BEX1Als2ySrhwneITWTqgp9NXCBFhg7kQhLsVyTYEW/Kp wHdbPjNGA2MG0ymS/WucoVG0+N5xvMfXECUosTWkHoty4ttdXVuqopwoVTM6 AY4wYJ3nrR82czSFLdjhIoI9BmHTkyYDVGikPl5TGR71XQLYyqnkp8ZEmkTN uaihL8OBgoVv6Y7SRdcLmXEoEulAMNufvj39ZopK9MJ+AOIWbROWAWCxBVNT zyLB6jDHxh0GHwmJgEswTDx1iEISxTjOgEdNpTUfEPYKrYjfdvkXMdGAHf+n yhYyEJM6BDg+3kCWBZoSUMXte8IzJGvdAjM9vItV8bqrCotQwRcWH/l8qaZn 25FxNoMQZlN15kUv2ubepG4C+0yNkaSNE6PkyhDjRq54jGZJQbjL3TYufTsb g5n0XybKebIGQgFcZvhHfJlgnlxeCyESa4gJZK018TbvauGEN9+RSkOrvVsv K4/qNNurx6o7cC8vMjKex87VDXU1l2lYzZpuSvXtF52ZCPjQMyXDo5f41Wdc N873X6I7vBt4bfcDSYNpig+ul3bsrw0113SzajCpNmyfXMTSgxtjcsMonVfT 3/r3ds1t5QmpnuZjzckV3gtwuvXVTl1P/W6hNIrbrlCbSKskL2CLgYx7qqsf snon4abotEW/dKMDW7GSSZCBI1HzFIdv8jMUB9VSIB2IZWZWI2JBRzCQbIIM wB64fZCHyzeAlHtAdH7yosjLtUiwV6dOALcUpsZYRadwEH5a+q6xMhrG29Nh eCW7ISDUgWEIqV5EP0jFoQqHeCH6/ae4cp6pFf0GZlNGAmVaPsaDYw/FP3j/ GoOVKwuUBUnchfkOFrJJxcUBgLcG+6HcvI5LcMaGoxAm8e4dM6Iv62bN9biD PrfmAPvLif2Km1Cw7q1vFiZ7nGZuFE/0RuEdhuuVYNZrVh+9G5FszVfuckgx DroMGRAEDqEhoIbkmHZzhSaHLuIDjpsawLZCSbiH/VxIgZDILkciRK0kqpg9 8dLLjsJTFUMcDiGoZWsQMQzsC9lmyL9TYN9HhvM8bsPEoIzSCOAFjkpA1JiB g0xIqAxVBYsWKxkk/EwgYAP6lRObt285xnGYlH4aeQDNPp94xIosWK7UazYg z698chxAM224EAcUhIsYAvLEICdyBtiEVKHgziz4n5dGHhE7tOw34FK2U4n3 QlojwCBtoLHEmZdC/FSYKO4r5BfERc8fBOg5GXOWNdAGApiKZoEJ4KZuLl4D apwCdEsBkLuZYDUUJQSkJGeqBCIlCl6mUQXq6y765JlWi8aW5qwzE13pS7l4 Vtdu4pZ1LqGzMTt2OWjopVBqGZYlJgZgFq6g2H4vdldsurxImUVMaWkCIQEi gLTqN8nweO3EMbW278tyKNE6GuF5q2DQ19eZgNgLT6m39cIPNILtGj9/1bz6 PiSno/Cs/NfsS+rjiHrQMAL5B6cJk+dLlAMINgiLVlqqRUYBH2EFE5GQdVsU BSMxKUqrqBWav3VD6JqYvSMww1ELetyXZJL+IwFhFFiv3BUjaQkNQMpGJNDB JhUoQkt4NBRJv4BsxNwy7DrNsPk9Y3AMBx+5Sg/kLj+KJq2BNPlG5XqoV93J Tdz4zIRRc7GMPKf3wEXJf4Ku7cSKdRLh4S3y+T3yxc0NU1MIYCRtU3kkjRrZ BENiD42X0P/E39YtdwHIKAVQzaMyDpJMS5W2v0M4zHzMJwEJfy+hLo2bLlCb wP3RQ9qOtng4rmaMTdIFg8bKXoKLpEbDIkOwa+csQtiP6rN9K0iaDiGmGs+Q DkptC3s30HAvGwlNAzKxgkYGX7qFgC8TQDYP0Gh9kyBunJTuTZBgcBRGaXiq brKYpy+YLuULwr8hiqF0ES1ZFRFYFKa9YYFKMb8MXluzw0yz5BF1OdDkvGQS 2MVAYXXzbUtLTTTVnWh6JN8nFsSdnuRIIiKCAD0m8IcWoLJfzvOCFUFglZ7U qozCGUAGAQKBjQOBD21+3Pj6SjGjEAL9OxZJPJrbee+qWnj55YYpsbSwpE78 y5c4YVhcXImFloVBMWODJbDs8M1JxZMaU47KKAYytIVScCYwig1h0wAd4G9d sissgVzWLANq2jTATYCp3AGBr8NRYj0A4I6kf8IA0DssXHXCRmsgD+TORYzY 0vsLlf5QRVLBIsXkr8LeCgd7YzRIZBAuoOsRRCKIExHfgqnm5hsfdgsli4KV ARylYFdmMgicCBSCxDaFZGO2QKCgos5CYuabNAs2bdD6F0Q6owGsy4/VJZq+ Rq7Ioq5kw3cnj5S6ifxaTyYcyrjmyZlJ2JtKKKiMUMgrAdZmJSZFCIIQkVoC 9p6tCpckEpMhLBKxIvk3G4yshqsBsZGw1RgBj6kmI/aMoIPjQ0AYEoS1DYM4 m4gy2Gv2W5bdCsGfMcVceMbGFQqNNnYfILhvFtSqs3lgjljzCV1jo6jC2Ldd kjIRnR8BTEKkC6uGERwaH/BnxZIpBA4yvFEIEpa49g1o0EkJeiwEUgBUMjoJ LUKcENDXmCG2PxFyRl4byaGaII+xSpkVT4KCOAGBYtHBDKoY0ANexdbTacC7 2rAlneEAXFJISvENDYNpRBAmadnWb+fV8HxGSpzGa1akGpSgVlRHrVGCojAz BdHAkejKMlQBQYMhQKUdGJCEfONJtKxMIlEnhtKVFUqQr10hxCvERVegZMJ1 yQbvNbiQShilGLXTIyn1Jb10gxdJZmu2x9Y6nXBsS5gYbDkcxzKa53IQzUsR VkE95xNfkoLiDLIZPFRGhMwBHEbiwrrwtWpM+ClgOdMXpIBCQixTu7ZtBWAj ESds6MyE0JYgjEF83TmIZeLabTrQVCqvGHsIULFhxSMBh4hlyiIIlphM7OjN JJm9djdRgY+r7d6Eh2RqJMGI8ihLy3xG3ycyKbXfeCjsSUqnHBSdLlMY1DbS b/Tj3DzZL+XjUd/BxiCWWG2pMXfM+48xKQ1moYmkeFCIg4x2GY4xI6B5NQRi leQx5dxQohhZ+AMggmChUslJMPKGj1K7z9RcjOEiT8NG28bRLzxKmsw6lzM6 cRGUL0EjYkvb4myhIGgkJlr6ysrLTUa28omVQvTPachy8dIEzWhDCV2c9Ezy 1Klj+0RemViIxgVz2l8E5LoHNwzA8SWxGx60VMTN8gaV6Rx1ECtBKqsKjaAY JRNCjJmaRSSIayA8RQQ4wwMDAaFXqVCdJhyRAVaMiNcapYYAH+kq8AloTYlf 1hSWTY4kowxLWsqd3iMztBQHngCenCfJYI9iV/cl0sSSY9NbEcUhdGgtDHRH oQdB+gqUyNqyaNGbGDaCnubb/iiEZioKhMmH2+THv5vgJ/SXVmpzsCEy5kQa 2DC8RJ1kl50lPdV+dSEtN+waK3qFvZtMg7Td4nEckTnRsFOvV8I3CbbzXCXS 2g0npJg5Zq+HjPrPk5Nh7xq8wuJU6lI1pF/YdBqRE38hkOxu5uQBRfnb4SSW Ykhg3GOSZ7zyl70DUrCIk+VUjIJC80om0J5CgYJymooKMA3neXmide6AwpYq Y3LJ+XSDBzBAWDnEuDSxJ7NwlxLMjpJNMUmKq6TJFQTT1GAwTnVa7wRCQXgN GN3TfKrQrEl5LKjP3sIKT4S3WZeGsNoOw1z2IusnbBITyGs7jxyFGCIQ5pzB KAHFCiMiIYgmkJDac0X2OWC6TIzPZvNuOtBIewgTnPy9dKLfvmQ4dzJN6NuI cqI+cqIW4jojhwsIHWUefhF4TmdqMS46gE7g9HXGnDzW3BzDCBkBAuaAsbEH QaMRJV1b7v6/VhSrNhz+OqvzSLFdxbvTh3sqWtIZs1NYt+YgVxcZ13Vy1FxU LhkOFUmYrBPjqpkxdHPmYStdZWxsoQYBhOg85kqEqvqwo0mKwe0DcEiHA1Q0 j49pnwcgSKQqEKajIxGzM0k3cF15MUOiMSAu3BEICh+qanAqxncCWT4XhJmF /Nup8BaKe/khJJf/MDPkBCFAEAVPutYI9EJvQPEYhM/jOaBpoHYSQkKWWsN6 R5ZR7kOVc2xgc65/2dmGto717Y0cHgXCC0gmGVG7CaIqhEJd5mGekoPIg4Py ceZBT5opYrzUMhovtAW4PAmhTyYSUydxE5mQ40hmMj0pFB2yPhOxLEw7QeHi EYTOcVCTIvhCyK4IPzAfACyxNeXLA1tIoGQuq5LNIeVk13huIqORpyMHeyeg wRe0r1QYZjL0lF/AxM2USO8YJTJC+KCMkYoIxXI1WMvMXIiadMM3TYb2c4bi jCGoWCSCiF+iYNyZjAtXIxSaE2nWBtgKFrAm49hZBzmYZFyB12ixIpcEmOAS vGVxgIZLRvm9zTmLE37lCF5FRL0o4pCoGY1t2hBrVww2jXaSg3DGrdaMRIRq EAZYDN6H2DC8fdNg49KsNAKBB54KJDFKGbx+XOqkMOp6HhOYlIXbYJqrYp0R oiOOjXIHMOmvF4zjnDYaSUrBVFQJwb1CCazSdolKRwcz+F7iHaa8hI0Z2F4V hoH7LBmQWEa3MArdPKx3ePcIC8cXsQOgPgYQrFDBLJd6B1P/xdyRThQkBZ4Y 4MA= --------------000502080708060603080000--