Re: [PATCH 18/28] check gdb_python_initialized everywhere

Pedro Alves
2013-05-15T16:43:35Z

On 05/07/2013 07:05 PM, Doug Evans wrote:
> On Tue, May 7, 2013 at 10:57 AM, Doug Evans <dje@google.com> wrote:
>> On Mon, Apr 22, 2013 at 11:27 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
>>>
>>> Tom> While sending out the series I realized I had meant to write a test case
>>> Tom> for this patch but forgot to. I will hold on to this one until I write
>>> Tom> it.
>>>
>>> This required a two-part series.
>>>
>>> The first patch just cleans up the existing gdb.gdb tests to remove
>>> duplication and to make it simpler to add new tests here.
>>>
>>> The second patch is the actual test case.
>>>
>>> Built and regtested on x86-64 Fedora 18.
>>
>> Hi.
>> I could use selftest-support in a test I'm writing.
>>
>> Can you check this in?
>> TIA
>
> Blech. I never liked adding one's name to files.
> The data is useless after a few years and does a disservice to all
> those who come after.

I agree. I see I ended up with my name mentioned in a
couple tests. I think I'll remove it.

I saw that glibc recently-ish started rejecting
submissions that included "contributed by"/"written by"/etc.
statements, even.

>
> I bring this up because this text in python-selftest.exp is completely bogus.
>
> +# This file was written by Andrew Cagney (cagney at redhat dot com),
> +# derived from xfullpath.exp (written by Joel Brobecker), derived from
> +# selftest.exp (written by Rob Savoye).

--
Pedro Alves