From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4379 invoked by alias); 21 May 2013 16:05:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4353 invoked by uid 89); 21 May 2013 16:05:45 -0000 X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 16:05:43 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4LG5gpF030996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 21 May 2013 12:05:42 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4LG5ehx021696; Tue, 21 May 2013 12:05:41 -0400 Message-ID: <519B9B54.9090907@redhat.com> Date: Tue, 21 May 2013 16:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jan Kratochvil CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch] Compilation regression with python-2.6 [Re: [PATCH 24/28] introduce gdb_pymodule_addobject] References: <87ehe638ww.fsf@fleche.redhat.com> <8761ziy43f.fsf@fleche.redhat.com> <20130521075803.GA404@host2.jankratochvil.net> In-Reply-To: <20130521075803.GA404@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00771.txt.bz2 On 05/21/2013 08:58 AM, Jan Kratochvil wrote: > ./python/py-utils.c: In function ‘gdb_pymodule_addobject’: > ./python/py-utils.c:445: error: suggest explicit braces to avoid ambiguous ‘else’ > > python-devel-2.7.3-13.fc18.x86_64 > /usr/include/python2.7/object.h > #define Py_DECREF(op) \ > do { \ > if (_Py_DEC_REFTOTAL _Py_REF_DEBUG_COMMA \ > --((PyObject*)(op))->ob_refcnt != 0) \ > _Py_CHECK_REFCNT(op) \ > else \ > _Py_Dealloc((PyObject *)(op)); \ > } while (0) > > python-devel-2.6.6-36.el6.x86_64 > /usr/include/python2.6/object.h > #define Py_DECREF(op) \ > if (_Py_DEC_REFTOTAL _Py_REF_DEBUG_COMMA \ > --((PyObject*)(op))->ob_refcnt != 0) \ > _Py_CHECK_REFCNT(op) \ > else \ > _Py_Dealloc((PyObject *)(op)) > > gdb/ > 2013-05-21 Jan Kratochvil > > Workaround Python 2.6. > * python/py-utils.c (gdb_pymodule_addobject): Wrap Py_DECREF into > a block. > > diff --git a/gdb/python/py-utils.c b/gdb/python/py-utils.c > index d87eb8c..23fcf3f 100644 > --- a/gdb/python/py-utils.c > +++ b/gdb/python/py-utils.c > @@ -443,6 +443,9 @@ gdb_pymodule_addobject (PyObject *module, const char *name, PyObject *object) > Py_INCREF (object); > result = PyModule_AddObject (module, name, object); > if (result < 0) > - Py_DECREF (object); > + { > + /* Python 2.6 did not wrap Py_DECREF in do { } while (0);. */ > + Py_DECREF (object); > + } > return result; > } > How about we handle this in a central place with something like: static inline void gdb_Py_DECREF (void *op) { Py_DECREF (op); } #undef Py_DECREF #define Py_DECREF(op) gdb_Py_DECREF (op) in gdb/python/python-internal.h? Then code that uses the macro wouldn't need to care. I went ahead and did a quick attempt at it. I checked the gdb.python/ tests all still passed for me. WDYT? --- gdb/python/py-utils.c | 11 ++--------- gdb/python/python-internal.h | 12 ++++++++++++ 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/gdb/python/py-utils.c b/gdb/python/py-utils.c index e78dee0..80bacf7 100644 --- a/gdb/python/py-utils.c +++ b/gdb/python/py-utils.c @@ -31,12 +31,8 @@ py_decref (void *p) { PyObject *py = p; - /* Note that we need the extra braces in this 'if' to avoid a - warning from gcc. */ if (py) - { - Py_DECREF (py); - } + Py_DECREF (py); } /* Return a new cleanup which will decrement the Python object's @@ -443,9 +439,6 @@ gdb_pymodule_addobject (PyObject *module, const char *name, PyObject *object) Py_INCREF (object); result = PyModule_AddObject (module, name, object); if (result < 0) - { - /* Python 2.6 did not wrap Py_DECREF in do { } while (0);. */ - Py_DECREF (object); - } + Py_DECREF (object); return result; } diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index b01efa1..b5c34b6 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -169,6 +169,18 @@ typedef unsigned long gdb_py_ulongest; #endif /* HAVE_LONG_LONG */ +/* Python 2.6 did not wrap Py_DECREF in 'do {...} while (0)', leading + to 'suggest explicit braces to avoid ambiguous ‘else’' gcc errors. + Wrap it ourselves, so that callers don't need to care. */ + +static inline void +gdb_Py_DECREF (void *op) +{ + Py_DECREF (op); +} + +#undef Py_DECREF +#define Py_DECREF(op) gdb_Py_DECREF (op) /* In order to be able to parse symtab_and_line_to_sal_object function a real symtab_and_line structure is needed. */