From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23217 invoked by alias); 21 May 2013 00:20:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23208 invoked by uid 89); 21 May 2013 00:20:41 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_CP autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 21 May 2013 00:20:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4L0KeoE010160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 May 2013 20:20:40 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4L0KcLP030472; Mon, 20 May 2013 20:20:39 -0400 Message-ID: <519ABDD6.3000803@redhat.com> Date: Tue, 21 May 2013 00:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 01/28] introduce CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF and use it References: <87ehe638ww.fsf@fleche.redhat.com> <87zjwu1tpa.fsf@fleche.redhat.com> <5193B075.4050508@redhat.com> <8761ydmn2y.fsf@fleche.redhat.com> In-Reply-To: <8761ydmn2y.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00751.txt.bz2 On 05/20/2013 09:08 PM, Tom Tromey wrote: >>>>>> >>>>> "Pedro" == Pedro Alves writes: >>> >> +#ifdef WITH_CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF_ATTRIBUTE >>> >> +#define CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF(ARG) \ >>> >> + __attribute__ ((cpychecker_type_object_for_typedef (ARG))) > Pedro> Could we have a comment here with a short hint at what this is > Pedro> all about? I assume from the patch that > Pedro> WITH_CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF_ATTRIBUTE is defined > Pedro> by cpychecker itself (not autoconf/config.h), but I can see > Pedro> future readers getting confused. > > Sure thing. > Here is the patch I am checking in. ... > --- a/gdb/python/python-internal.h > +++ b/gdb/python/python-internal.h > @@ -20,6 +20,19 @@ > #ifndef GDB_PYTHON_INTERNAL_H > #define GDB_PYTHON_INTERNAL_H > > +/* These WITH_* macros are defined by the CPython API checker that > + comes with the Python plugin for GCC. See: > + https://gcc-python-plugin.readthedocs.org/en/latest/cpychecker.html > + The checker defines a WITH_ macro for each attribute it > + exposes. */ > + > +#ifdef WITH_CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF_ATTRIBUTE > +#define CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF(ARG) \ > + __attribute__ ((cpychecker_type_object_for_typedef (ARG))) > +#else > +#define CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF(ARG) > +#endif > + That's perfect. Thanks! -- -- Pedro Alves