Re: [PATCH 3/5] range stepping: gdb

Yao Qi
2013-05-23T00:47:03Z

On 05/21/2013 02:43 AM, Pedro Alves wrote:
> diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h
> index a9f8a94..e93b965 100644
> --- a/gdb/gdbthread.h
> +++ b/gdb/gdbthread.h
> @@ -65,6 +65,13 @@ struct thread_control_state
> CORE_ADDR step_range_start; /* Inclusive */
> CORE_ADDR step_range_end; /* Exclusive */
>
> + /* If GDB issues a target step request, and this is nonzero, the
> + target should single-step this thread once, and then continue
> + single-stepping it without GDB involvement as long as thread
^^^
Nit: How about "GDB core"? Since we didn't treat range stepping as
remote-specific, so other targets, such as native target, may implement
range stepping, and it is part of GDB.

This patch looks good to me.

--
Yao (é½å°§)